Stdlib: Locale getDisplayLanguage/Region/Script/Variant + getAllVariants (#20755)#20791
Merged
Conversation
5 tasks
…nts (#20755) Add php-src Locale display-component getters and getAllVariants (plus procedural aliases) on the existing English/ICU-fallback VmLocale path. Note: Locale::getKeywordValue/setKeywordValue are not in php-src 8.4 locale.stub.php — getKeywords already covers keyword maps (#20738). Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
fix/20755-locale-display-methods
branch
from
July 19, 2026 02:16
eba6138 to
18fb1ee
Compare
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locale::getDisplayLanguage/getDisplayRegion/getDisplayScript/getDisplayVariant/getAllVariantsplus procedurallocale_get_display_*/locale_get_all_variantson the existing English-approximationVmLocalepath (php-srcext/intl/locale/).getKeywordValue/setKeywordValueare not in php-src 8.4locale.stub.php; keyword maps remain viagetKeywords(Stdlib: Locale::canonicalize()/parseLocale()/composeLocale()/getKeywords() missing after #6696/#20036 (ext/intl/locale) #20738).ext/intl/files. Gen-0 sidecar stamp remains stale on master (waive withBOOTSTRAP_ALLOW_STALE_SIDECAR=1; blob refresh is a separate bootstrap PR).php-src reference:
ext/intl/locale/locale.stub.php,locale_methods.cPHP-in-PHP: no new C runtime.
Closes #20755
Test plan
PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/issue_20755_locale_display_methods.php— matches Zend 8.2+intlPHP_COMPILER_PROFILE=8.4 php bin/jit.php test/repro/issue_20755_locale_display_methods.phpvendor/bin/phpunit --filter test_locale_display_methodsvendor/bin/phpunit --filter locale_display_methods test/compliance/VMTest.phpphp script/bootstrap-inventory.php --check→ OK 5840/5840Verification transcript (VM = Zend)
Made with Cursor