Bootstrap: skip null include-binding ASSIGN operands (#22642)#22974
Merged
Conversation
Honest full-spine AOT (r15) TypeError'd in OperandName::resolve when getOperand() returned null for ASSIGN slots absent from block scope. Null-guard those walks so gen-0 refresh can continue past OpCodeNames. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OperandName::resolve(): Argument #1 ($op) must be of type PHPCfg\Operand, null givenatIncludeBindingJitHelper.php:270while compiling the honest spine (LAST_ENTRY=/compiler/lib/OpCodeNames.php).Block::getOperand()can return null when an ASSIGN slot index is absent from the current block scope; the include-binding walk passed that null intoOperandName::resolve().lastAssignVariableForNameInBlock,variableFromCallerAssignConstant, andcountAssignsToName(PHP-in-PHP; no C).Refs #22642 (does not close — verified-fresh sidecars still required). Unblocks the next exclusive spine attempt (r16).
php-src / design
Zend/zend_execute.c); this is compile-time binding analysis inext/standard/IncludeBindingJitHelper.php.Test plan
php test/repro/issue_22642_include_binding_null_operand.php→ok nullvendor/bin/phpunit --filter IncludeBindingNullOperandTest→ OK (3)--filter 'IncludeBindingNullOperandTest|IncludeBindingNestedAppNameTest|IncludeHelperShrinkTest'→ OK (10)Verification transcript
C runtime: 0 lines added.
Made with Cursor