Language: deny Generator serialize/unserialize like Zend (#23044)#23082
Merged
Conversation
Match php-src zend_generators.c serialize/unserialize deny handlers so serialize($generator) throws Exception instead of emitting O: wire. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-23044-generator-serialize
branch
from
July 25, 2026 17:47
44362cd to
232ca35
Compare
4 tasks
PurHur
added a commit
that referenced
this pull request
Jul 25, 2026
3 tasks
PurHur
added a commit
that referenced
this pull request
Jul 25, 2026
…23085) * Trust: restamp gen-0 fingerprint after #23078–#23083 drift (#10533) Pillar 1: north-star5-verify --fast step 4f-m failed (94f60af8… vs live bf9335d2…) after empty()/CurlHandle/SensitiveParameterValue/GD2/SimpleXML serialize merges. Stamp with BOOTSTRAP_GEN0_ALLOW_UNVERIFIED_STAMP=1 so provenance stays unverified-restamp (#22966). Honest verified-fresh rebuild remains #22717. Co-authored-by: Cursor <cursoragent@cursor.com> * Trust: restamp gen-0 fingerprint after #23082/#23084 drift (#10533) Master moved (Generator/WeakMap serialize) while the prior restamp was in flight; live fingerprint is now 95e2817e… (was bf9335d2…). Keep provenance=unverified-restamp. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serialize()/unserialize()ofGeneratorwith Zend-identicalExceptionmessages (Zend/zend_generators.cserialize/unserialize deny).VmSerialize(encode + export + unserialize header)..phpt+ repro; Closure deny asserted first.Closes #23044
php-src reference
Zend/zend_generators.c—zend_class_serialize_deny/zend_class_unserialize_denyPHP implementation
ext/standard/VmSerialize.php(PHP-in-PHP; no newruntime/*.c)Test plan
php bin/vm.php test/repro/issue_23044_generator_serialize.php./script/phpunit.sh --filter generator_serialize_disallowed→ OK (2 tests)generator_serialize_disallowed.phptVerification
Note: full
GeneratorVMTeststill has a pre-existing red ongenerator_finally_early_close.phpt(FIN_UNSETmissing) on this tree — unrelated to serialize deny.Trust snapshot: inventory OK;
north-star5-fastred on gen-0 stale (#22642) — unrelated pillar 1.