Stdlib: DateTime accepts Y-m-d H:i without seconds (#25309) - #25340
Merged
Conversation
Relax VmDateTimeNative absolute ISO regex so hour+minute parses with seconds defaulting to 0, matching timelib/php-src parse_date. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VmDateTimeNative::parseDateTimeAbsolute()ISO regex soY-m-d H:i/Y-m-dTH:iparse with seconds defaulting to0(timelib / php-srcparse_date.re).DateTime,DateTimeImmutable, anddate_create().Closes #25309
Test plan
test/repro/maintainer_gap_datetime_hour_minute.phpvendor/bin/phpunit --filter datetime_hour_minute_no_seconds— OK (2 tests)new DateTime(...)segfaults on master for this surface (pre-existing)php-src reference
ext/date/lib/parse_date.re— absoluteY-M-D+ optional time with optional secondsMade with Cursor