Skip to content

php-in-php: lower locale_get_default() on AOT/JIT (#27369) - #27698

Merged
PurHur merged 1 commit into
masterfrom
agent/runtime-php-locale-get-default-27369
Aug 5, 2026
Merged

php-in-php: lower locale_get_default() on AOT/JIT (#27369)#27698
PurHur merged 1 commit into
masterfrom
agent/runtime-php-locale-get-default-27369

Conversation

@PurHur

@PurHur PurHur commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

php-src reference

  • ext/intl/locale/locale_methods.clocale_get_default

C runtime shrink

No new C. Behavior lives in ext/intl/LocaleDefaultJitHelper.php + lib/JIT/Builtin/LocaleParser.php.

Verification

# Issue repro — was compile exit 2 "deferred; use VM"
cat >/tmp/locale_get_default.php <<'P'
<?php
echo locale_get_default(), PHP_EOL;
P
php /tmp/locale_get_default.php          # en_US_POSIX
php bin/vm.php /tmp/locale_get_default.php  # en_US_POSIX
php bin/compile.php -o /tmp/locale_get_default.bin /tmp/locale_get_default.php && /tmp/locale_get_default.bin  # en_US_POSIX

vendor/bin/phpunit test/unit/LocaleGetDefaultRuntimeShrinkTest.php test/unit/LocaleParserRuntimeShrinkTest.php
make bootstrap-selfhost-vm-driver-execute-probe  # OK
php script/check-selfhost-spine-coverage-sync.php  # OK 7007/7007

Not run: full ci-fast.sh (in flight), compliance locale_get_default.phpt shard, locale_set_default (still deferred).

Closes #27369

Made with Cursor

…tHelper (#27369)

Route locale_get_default() through JitVmHelperLink + a slim NestedJIT helper
that mirrors VmLocale::getDefault() without pulling ICU FFI into user-script
AOT. Removes the deferred compile refusal; VM path unchanged.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 87055bd into master Aug 5, 2026
0 of 2 checks passed
@PurHur
PurHur deleted the agent/runtime-php-locale-get-default-27369 branch August 5, 2026 08:05
PurHur added a commit that referenced this pull request Aug 5, 2026
…27696)

north-star5-verify-fast step 4f-m failed: lowering_source_fingerprint
lagged live sources after SimpleXML xpath + locale_get_default landings.
Zend-rebuild the committed argv driver with verified-fresh provenance
(no restamp); inventory doc picks up LocaleDefaultJitHelper.

Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur added a commit that referenced this pull request Aug 5, 2026
…27696) (#27701)

north-star5-verify-fast step 4f-m failed: lowering_source_fingerprint
lagged live sources after SimpleXML xpath + locale_get_default landings.
Zend-rebuild the committed argv driver with verified-fresh provenance
(no restamp); inventory doc picks up LocaleDefaultJitHelper.

Co-authored-by: PurHur <PurHur@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stdlib: AOT/JIT locale_get_default() still deferred — re-#9576 (ext/intl/locale)

1 participant