php-in-php: lower locale_get_default() on AOT/JIT (#27369) - #27698
Merged
Conversation
…tHelper (#27369) Route locale_get_default() through JitVmHelperLink + a slim NestedJIT helper that mirrors VmLocale::getDefault() without pulling ICU FFI into user-script AOT. Removes the deferred compile refusal; VM path unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 5, 2026
…27696) north-star5-verify-fast step 4f-m failed: lowering_source_fingerprint lagged live sources after SimpleXML xpath + locale_get_default landings. Zend-rebuild the committed argv driver with verified-fresh provenance (no restamp); inventory doc picks up LocaleDefaultJitHelper. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
PurHur
added a commit
that referenced
this pull request
Aug 5, 2026
…27696) (#27701) north-star5-verify-fast step 4f-m failed: lowering_source_fingerprint lagged live sources after SimpleXML xpath + locale_get_default landings. Zend-rebuild the committed argv driver with verified-fresh provenance (no restamp); inventory doc picks up LocaleDefaultJitHelper. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
locale_get_default()JIT/AOT defer refusal (Stdlib: locale_get_default()/locale_set_default() and Locale class missing (ext/intl/php_intl.c) #9576) by routing throughJitVmHelperLink→ new slimLocaleDefaultJitHelperLocaleDefaultJitHelpermirrorsVmLocale::getDefault()semantics (ini + LC_* env) without NestedJIT-compiling all ofVmLocale(ICU FFI static init SEGV'd under user-script AOT)execute()path unchanged; JITTest skip forlocale_get_defaultremovedphp-src reference
ext/intl/locale/locale_methods.c—locale_get_defaultC runtime shrink
No new C. Behavior lives in
ext/intl/LocaleDefaultJitHelper.php+lib/JIT/Builtin/LocaleParser.php.Verification
Not run: full
ci-fast.sh(in flight), compliancelocale_get_default.phptshard,locale_set_default(still deferred).Closes #27369
Made with Cursor