Stdlib: RoundingMode unit enum; drop phantom PHP_ROUND_* (#28535) - #28545
Merged
Conversation
Match php-src: RoundingMode is not int-backed; PHP_ROUND_CEILING/FLOOR/TOWARD_ZERO/AWAY_FROM_ZERO stay undefined; round() Reflection $mode is RoundingMode|int defaulting to HalfAwayFromZero. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RoundingModeas a unit enum (VM + JIT), not int-backed.PHP_ROUND_CEILING/FLOOR/TOWARD_ZERO/AWAY_FROM_ZEROviadefined()/ ConstFetch (legacy Half* ints 1–4 remain).round()$modeisRoundingMode|intwith defaultRoundingMode::HalfAwayFromZero(constant name exposed).Closes #28535
php-src reference
ext/standard/basic_functions.stub.php—enum RoundingModeext/standard/BuiltinEnums.php,StdlibConstants.php,BuiltinInternalArgInfo/DefaultValues, JITObject_.phpTest plan
PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/issue_28535_roundingmode_unit_enum.phpstdlib/rounding_mode_unit_enum_28535EXPECT matchrounding_mode_enumstill greenSibling behavioral wrong-output on negatives: #28534 (next).
Made with Cursor