Split-TU: extract HoistedMultiArgSiblingFuncCallChain (#36387) - #37003
Merged
Conversation
Move hoisted multi-arg sibling FuncCall chain helpers (~1006 lines) out of SiblingInlineFuncCallProducers so gen-0 split-TU can hollow a smaller Concern TU. Leaves SiblingInlineFuncCallProducers as a thin hub; New_/deferred already lives in EnsureDeferredSiblingAndInlineNewProducers (#37000). Ratchet Compiler hub budget 1088→1091 and spine 8325→8326. Mirrors php-src Zend/zend_execute.c ZEND_SEND_* adjacent call-arg wiring — move-only. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HoistedMultiArgSiblingFuncCallChain(~1006 lines) out ofSiblingInlineFuncCallProducers—siblingMultiArgFuncCallProducerTargetArgIndexthroughfirstContiguousHoistedFuncCallProducerForMultiArgConsumer(Part of Performance: compile-time targets and gate — hello-world ≤ 3 s warm, MiniWebApp ≤ 10 s, 400 statements per function in < 5 s, one-file edit rebuild < 25 % of full, spine gen-0 < 30 min with split-TU (script/bench-gate.php --compile, bin/compile.php, lib/Compiler.php) (re-#36224 slice 2, re-#36199) #36387 / prior Build: spine split-TU — per-module LLVM objects instead of 8053-file monolith (gen-0 rebuild) #36147).SiblingInlineFuncCallProducersas a thin hub; New_/deferred already inEnsureDeferredSiblingAndInlineNewProducers(Split-TU: extract EnsureDeferredSiblingAndInlineNewProducers (#36387) #37000).require_once+ sidecar stamp SHA-1; Compiler hub budget 1091→1094; spine 8326→8327 (after rebase onto Split-TU: extract HoistedSiblingFeedAndArrayKeysArgSendRewire (#36387) #37002).Zend/zend_execute.cZEND_SEND_*adjacent call-arg wiring — no behavior change (opcode-corpus-md50 changed).Closes nothing (Part of #36387).
Test plan
php script/check-size-budgets.php→ OK (lib/Compiler.php1094/1094)php script/check-selfhost-spine-sidecar-sync.php→ OKphp script/check-selfhost-spine-coverage-sync.php→ OK (8327/8327)php script/check-selfhost-spine-count-sync.php→ OKphp script/opcode-corpus-md5.php --check→ OK (0 changed)./script/aot-smoke.sh→ 9/9 + size gate OKmake north-star5-verify-fast→ OK on pre-rebase tip (spine 8326); post-rebase aot-smoke 9/9 + spine sync 8327/8327lane overflow: #36143–#36148 closed; Focus split-TU continuation of #36147.
Made with Cursor