Split-TU: extract ExplodeIteratorChunkWalkAndTrailingComparatorCallArgSends (#36387) - #37043
Merged
PurHur merged 1 commit intoSep 6, 2026
Merged
Conversation
…gSends (#36387) Move explode / iterator_to_array / array_chunk / array_walk / closure-pair / trailing-comparator inline ARG_SEND compilers (~635 lines) out of CompileInlineSpecializedCallArgSends so gen-0 split-TU can hollow a smaller Concern TU (complementary to concurrent ArrayPad→date_sun peers). Hub wire + spine require + sidecar stamp; ratchet Compiler hub budget 1133→1136 and spine 8340→8341. Move-only — mirrors php-src Zend/zend_compile.c call-arg send operand wiring for specialized builtins. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
deleted the
agent/issue-36387-explode-chunk-walk-comparator-sends
branch
September 6, 2026 18:30
This was referenced Sep 6, 2026
PurHur
added a commit
that referenced
this pull request
Sep 6, 2026
Move remaining array_pad / unpack / extract / date_sun_* inline ARG_SEND compilers (~670 lines) out of CompileInlineSpecializedCallArgSends so gen-0 split-TU can hollow that Concern TU (empty hub; complements #37043 ExplodeIterator extract). Hub wire + spine require + sidecar stamp; ratchet Compiler hub budget 1136→1139 and spine 8341→8342. Move-only — mirrors php-src Zend/zend_compile.c and ext/standard array/date call-arg send wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Sep 6, 2026
Move remaining array_pad / unpack / extract / date_sun_* inline ARG_SEND compilers (~670 lines) out of CompileInlineSpecializedCallArgSends so gen-0 split-TU can hollow that Concern TU (empty hub; complements #37043 ExplodeIterator extract). Hub wire + spine require + sidecar stamp; ratchet Compiler hub budget 1136→1139 and spine 8341→8342. Move-only — mirrors php-src Zend/zend_compile.c and ext/standard array/date call-arg send wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
PurHur
added a commit
that referenced
this pull request
Sep 6, 2026
#37052) Move remaining array_pad / unpack / extract / date_sun_* inline ARG_SEND compilers (~670 lines) out of CompileInlineSpecializedCallArgSends so gen-0 split-TU can hollow that Concern TU (empty hub; complements #37043 ExplodeIterator extract). Hub wire + spine require + sidecar stamp; ratchet Compiler hub budget 1136→1139 and spine 8341→8342. Move-only — mirrors php-src Zend/zend_compile.c and ext/standard array/date call-arg send wiring. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ARG_SENDcompilers (~635 lines) fromCompileInlineSpecializedCallArgSendsintoExplodeIteratorChunkWalkAndTrailingComparatorCallArgSends..m3_compiler_lib_sidecar.sha(SHA-1 of spine entry) + size-budget ratchet1133→1136; spine 8340→8341.Zend/zend_compile.ccall-arg send operand wiring for specialized builtins.Closes nothing (tracker remains open); Part of #36387.
Test plan
php -lon new Concern +Compiler.php./script/check-generated-docs.sh→ OK./script/aot-smoke.sh→ 9/9 + size gate OKmake north-star5-verify-fast→ OK (spine 8341/8341)opcode-corpus-md5 --checkOK (move-only; aggregate unchanged)differential-sweep.sh --aot --repeat 3(move-only Concern extract; no lowering change)north-star5-verify --strictMade with Cursor