Bootstrap Phase C: TYPE_THROW JIT + require_chain link (#57, #120)#538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TYPE_THROWJIT lowering (abort()+ LLVM unreachable) and register libcabortin the JIT module.TYPE_CAST_STRINGJIT viaJitNativeString::coerceso(string)casts inrequire_chain/main.phpcompile.test/bootstrap-aot/throw_logic.phpandtest/bootstrap-aot/require_chain/main.phptoaot_link_targets(removed from$pendingUserFunc).throw_logicfixture to use an in-fileBootstrapThrowMarkerclass (avoids unresolved\LogicExceptionat link time).docs/bootstrap-profile.json— 9 Phase C link targets;make bootstrap-aot-linkpasses locally.Test plan
php script/bootstrap-profile.php --check./script/bootstrap-aot-link.sh(9 targets OK)vendor/bin/phpunit test/unit/BootstrapProfileTest.phpCloses #57 (throw terminal link path). Contributes to #120 (require_once chain link).
Made with Cursor