Sync bootstrap link pending after #538/#545#548
Merged
Conversation
Restore TYPE_THROW and TYPE_CAST_STRING JIT lowering lost when try/catch CFG landed (aa4940f). Promote require_chain and throw_logic to aot_link_targets; keep try_catch lint-only until unwind link works. Regenerate bootstrap-profile.json (11 link targets) and refresh docs. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TYPE_THROW(abort + unreachable) andTYPE_CAST_STRINGJIT lowering reverted when try/catch CFG landed in aa4940f.require_chain/main.phpandthrow_logic.phpfrom$pendingUserFunc; keeptry_catch.phppending (LLVM block terminator gap).docs/bootstrap-profile.json— 11 Phase Caot_link_targets.docs/bootstrap-selfhost.mdand README link-pending list.Test plan
php script/bootstrap-profile.php --check./script/bootstrap-aot-link.sh(11 targets OK)vendor/bin/phpunit test/unit/BootstrapProfileTest.phpMade with Cursor