Environment propagation for font, color, and disabled#38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style modifiers set on a container now apply to its whole subtree — SwiftUI's environment semantics for
.font,.foregroundColor, and.disabled. Previously these only had an effect when attached directly to aTextorButton; on aVStackthey were silently ignored.How it works
Pure interpreter change (the modifiers already emit on any view from earlier tiers). Modeled the same way Compose models its own text environment — CompositionLocals:
LocalInheritedFontSize/LocalInheritedFontWeight/LocalInheritedColor/LocalInheritedDisabledRender(node)folds the node's ownfont/foregroundColor/disabledmodifiers into these before rendering its subtree (right alongside the existing animation-spec provider).RenderTextstarts from the inherited values; its own modifiers override them.Buttonis disabled when either its own or an inherited.disabled(true)is in scope.Explicit-wins is automatic: a child's own
.fontoverrides the inherited one.Verification
.font(.title); two inheriting.foregroundColor(.blue); a child.font(.caption)overriding an inherited title; combined headline+purple; and a.disabled(true)container whose buttons are dimmed and non-interactive (tap count stays 0)Deferred
Inherited
.disabledfully disablesButtonand visually dims the subtree (container alpha), but does not yet setenabled = falseonToggle/Slider/TextField..italic/.lineLimit/.multilineTextAlignmentremain Text-local (not propagated).