Subtree dirty-tracking with tree patches#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-evaluates only the subtree whose state actually changed, hands the interpreter a patch instead of a full root, and moves scalar prop values off the JSON path.
ViewHost.evaluateUpdate(): returns a patch when all dirt lands at one anchored path; falls back to a full pass for first render,@Observablemutations, multi-path writes, lazy-row state, or when the subtree republished changed ancestor-visible data (title, search state, preferences).TreeStore.patch: splices the re-materialized subtree by node id with copy-on-spine sharing; a miss returns false and the bridge recovers with a full update.contentVersionincluded in the rowrememberkey, so cached rows re-fetch exactly when their container re-evaluated.Json.parseToJsonElementper scalar, no string escaping on the Swift side.Testing
withAnimation, and searchable filtering all behave correctly on the typed transport.