Migrate from BitMaskOptionSet to native OptionSet#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the deprecated
BitMaskOptionSet/BitMaskOption(both marked@available(*, deprecated, message: "Use OptionSet instead")in the Bluetooth package) with native SwiftOptionSetstructs. This clears everyBitMaskOptionSet is deprecatedwarning in the build.Each flag enum +
BitMaskOptionSet<Flag>pair becomes a singleOptionSetstruct, keeping the original type name so public API and the DocC references stay intact — the same idiom the Bluetooth package uses for its own flag types (e.g.CTEType).RFCOMMFlagenum: BitMaskOptionstruct: OptionSet(UInt32)RFCOMMLinkModeenum: BitMaskOptionstruct: OptionSet(UInt16)HCIDeviceFlagenum: BitMaskOption(bit positions)struct: OptionSet(UInt32,1<<nmasks)HostController.ScanOptionenum: BitMaskOptionstruct: OptionSet(UInt16)HCIDeviceOptions.flags/containswere rewritten toOptionSetsemantics (intersection(.all)/isSuperset(of:)). This also fixes a latent bug: the oldBitMaskOptionSet<HCIDeviceFlag>could not represent.up(bit position 0 collapsed to "empty"), sooptions.flagssilently dropped it — the nativeOptionSetmasks (1<<n) represent it correctly.Verification
BitMaskOptionSetdeprecation warningsBase branch
Targets
feature/code-coveragerather thanmaster: this branch was cut from it and depends on that branch's Bluetooth-master API fixes (.data→Data(_:), updated UUID namespaces) to build against the currentBluetoothdependency. It will retarget tomasterautomatically once #52 merges.