Skip to content

Conversation

@nobs2p
Copy link
Contributor

@nobs2p nobs2p commented May 17, 2025

  • Fixed validation of HOST and PORT parameters for FORWARD sessions:
    • Improved IP address parsing with fallback to 127.0.0.1 if invalid
  • Added checks for required parameters (ID, HOST, PORT)
  • General cleanup and refactoring for improved readability and stability

@nobs2p nobs2p closed this May 17, 2025
@nobs2p nobs2p reopened this May 17, 2025
@nobs2p nobs2p force-pushed the fix_SAM_FORWARD branch from 6e32de0 to a7cd3fc Compare May 17, 2025 21:42
@Vort
Copy link
Contributor

Vort commented May 18, 2025

Added checks for required parameters (ID, HOST, PORT)

The thing is HOST is actually not required.
Note square brackets here: [HOST=$host].
Following text also confirms this:

$host is the hostname or IP address of the socket server to which SAM will forward connection requests. If not given, SAM takes the IP of the socket that issued the forward command.

@nobs2p nobs2p force-pushed the fix_SAM_FORWARD branch from a7cd3fc to 52fa049 Compare May 19, 2025 20:52
…StreamForward

- Fixed validation of HOST and PORT parameters for FORWARD sessions:
  - Improved IP address parsing with fallback to 127.0.0.1 if invalid
- Added checks for required parameters (ID, HOST, PORT)
- General cleanup and refactoring for improved readability and stability

Signed-off-by: nobs2p <nobs2p@i2pmail.org>
@nobs2p nobs2p force-pushed the fix_SAM_FORWARD branch from 52fa049 to d440b5b Compare May 19, 2025 21:08
@orignal orignal merged commit f93b354 into PurpleI2P:openssl May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants