Sanitize html inputs on Events and Jobs #412
Conversation
edvm
left a comment
edvm
left a comment
There was a problem hiding this comment.
Se ve genial! Muchas gracias! 👍
| "jQuery": jQuery.noConflict(true) | ||
| }; | ||
| var jQuery = django.jQuery; | ||
| var $=jQuery; |
There was a problem hiding this comment.
@matuu Genial el PR! . Pregunto de curioso, porque tenemos esto de jquery.noConflict(true) por aca? No sabia lo que hacia, asi que me fije la doc en: https://api.jquery.com/jquery.noconflict/ y dice que en caso de tener dos o mas versiones de jquery cargadas, $.noConflict(true) devuelve las referencias a $ a la versión 'anterior'. Estamos en esa situación? por ahi un comment que aclare el porque de esas lineas seria genial 👍
There was a problem hiding this comment.
El plguin que sugiere tags (django-taggit-autosuggest) está pensado para funcionar en el admin de django, entonces espera que django.jQuery esté definido. Por eso no se veía en funcionamiento ese plugin. Esta es la solución que encontré, pero es cierto que quizás sea media rebuscada. Dejame ver si puedo solucionarlo de otra manera.
There was a problem hiding this comment.
@matuu no te hagas problema. Nomas si agregas esto en el comment, con eso ya queda joya (por si alguien lee eso, sepa para que esta :) 👍 Con eso comentado, ya mergeo luego a dev este PR 👍
* add flake8 to tests. * pep8 police * move flake8 config to .flake8 * fix pep8 args * add python3.5 and 3.6 to travis-ci * speed up tests * Add a general word-wrap style rule * Use docker image from dockerhub. Makefile with command alias * Adds gender field to EventRegistration model * Adds migration related to new gender field * Adds gender field to corresponding forms * Show the gender in registered list and CSV. * fix pep8 * Change the homepage context * Replaces Ultimas Noticias and Últmos Trabajos with a new section * Refactor the homepage as a class-based view * Added factories for testing * Added tests for the new homepage * Sanitize html inputs on Events and Jobs (#412) * fix autosuggest js on jobs form * refs #409 #410 add html_sanitizer to description field of Job and Event * refs #409 410 add tests to Job and Event views * remove duplicate requeriment * adjust code to pycodestyle * fix wrong exception class * Update job_form.html * added normalize_tags function on job utils (#418) * 407 migration to fix tags (#419) * Arreglo error de linter * Added new makemigrations shortcut * added missing migration * Adds a migration to clean the tags * split function to use ir * Use tag normalization function in migration * #346 autoslug (#420) * added autoslug fields to events * fixed url position * Fixed migrations (#423) * Resolviendo issue #383 (#425) * Resolviendo issue #383 Agregue el EMAIL_CONFIRMATION_LA_DOMAIN con el valor "python.org.ar". Probado en un servidor debug funciona correctamente el link. * arreglando error de flake8 * 417 sponsored jobs (#424) * Added rank for pycompanies, updated joblist view with sponsored jobs, added ac.civil badget to pycompanies * Changes after code review * moved css styles and other html stuff * Fixed typo and added one test with rank==0
3 participants
Uh oh!
There was an error while loading. Please reload this page.