Resolviendo issue #383 #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agregue el EMAIL_CONFIRMATION_LA_DOMAIN con el valor "python.org.ar". Probado en un servidor debug funciona correctamente el link.
Resolviendo issue PyAr#383
edvm
reviewed
May 3, 2018
Contributor
There was a problem hiding this comment.
@mikiangel10 genial! Un ultimo detalle, podes ver que los tests de Travis no están pasando (lo podes ver acá en el PR abajo de todo):
Si le haces click en details vas a ver:
Cuando te fijas en 144.3, revisando el Job log, vas a encontrar lo siguiente:
El error es de estilos (flake8), se queja de que no hay espacios en blanco entre EMAIL_CONFIRM_LA_DOMAIN, el = y python.org.ar, fijate como estan los de abajo:
@mikiangel10 podes por favor actualizar el PR con este fix? asi puedo mergearlo? 👍 :D
Author
|
Ahi está. Barbaro, nunca habia visto como se pasan los tests. Gracias por la paciencia. |
Contributor
|
Mergeado, muchas gracias @mikiangel10 ! :D |
gilgamezh
added a commit
that referenced
this pull request
Jun 2, 2018
* add flake8 to tests. * pep8 police * move flake8 config to .flake8 * fix pep8 args * add python3.5 and 3.6 to travis-ci * speed up tests * Add a general word-wrap style rule * Use docker image from dockerhub. Makefile with command alias * Adds gender field to EventRegistration model * Adds migration related to new gender field * Adds gender field to corresponding forms * Show the gender in registered list and CSV. * fix pep8 * Change the homepage context * Replaces Ultimas Noticias and Últmos Trabajos with a new section * Refactor the homepage as a class-based view * Added factories for testing * Added tests for the new homepage * Sanitize html inputs on Events and Jobs (#412) * fix autosuggest js on jobs form * refs #409 #410 add html_sanitizer to description field of Job and Event * refs #409 410 add tests to Job and Event views * remove duplicate requeriment * adjust code to pycodestyle * fix wrong exception class * Update job_form.html * added normalize_tags function on job utils (#418) * 407 migration to fix tags (#419) * Arreglo error de linter * Added new makemigrations shortcut * added missing migration * Adds a migration to clean the tags * split function to use ir * Use tag normalization function in migration * #346 autoslug (#420) * added autoslug fields to events * fixed url position * Fixed migrations (#423) * Resolviendo issue #383 (#425) * Resolviendo issue #383 Agregue el EMAIL_CONFIRMATION_LA_DOMAIN con el valor "python.org.ar". Probado en un servidor debug funciona correctamente el link. * arreglando error de flake8 * 417 sponsored jobs (#424) * Added rank for pycompanies, updated joblist view with sponsored jobs, added ac.civil badget to pycompanies * Changes after code review * moved css styles and other html stuff * Fixed typo and added one test with rank==0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.