Skip to content

chore: rename env profile to profile_smoke.yaml (#161 step 6) #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
Jul 23, 2026
Merged

chore: rename env profile to profile_smoke.yaml (#161 step 6) #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/scripts/run_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""
Run the workspace smoke test suite.

Reads `smoke_tests.txt` from the workspace root and `config/build/env_vars.yaml`
Reads `smoke_tests.txt` from the workspace root and `config/build/profile_smoke.yaml`
for per-script env var overrides, then runs each listed script with the
appropriate environment. Continues through failures and exits non-zero
if any script failed.
Expand All @@ -23,7 +23,10 @@

WORKSPACE = Path(__file__).resolve().parents[2]
SMOKE_FILE = WORKSPACE / "smoke_tests.txt"
ENV_VARS_FILE = WORKSPACE / "config" / "build" / "env_vars.yaml"
ENV_VARS_FILE = WORKSPACE / "config" / "build" / "profile_smoke.yaml"
if not ENV_VARS_FILE.exists():
# Legacy fallback; removed at the stage-3 cleanup once env_vars.yaml is gone.
ENV_VARS_FILE = WORKSPACE / "config" / "build" / "env_vars.yaml"
SCRIPTS_DIR = WORKSPACE / "scripts"


Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ cap grids/masks).
## Testing

On CI, every PR is gated on Python **3.12 and 3.13** by `smoke_tests.yml` (runs
`python .github/scripts/run_smoke.py`, driven by `smoke_tests.txt` + `config/build/env_vars.yaml` —
`python .github/scripts/run_smoke.py`, driven by `smoke_tests.txt` + `config/build/profile_smoke.yaml` —
the definition of green), `navigator_check.yml` (PyAutoHands's reusable navigator-catalogue check;
see *Notebooks vs Scripts*), and `url_check.yml` (link checking). The smoke and navigator jobs check
out **PyAutoHands** as a sibling and run the PyAuto* libraries from the **same-named branch** of each
Expand Down
2 changes: 1 addition & 1 deletion config/build/env_vars.yaml → config/build/profile_smoke.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ defaults:
# 2026-07-23: the remaining five overrides were removed for the same reason —
# `imaging/start_here`, `interferometer/start_here`, `group/start_here`,
# `multi/start_here` and `guides/results/` are all autolens_workspace paths
# copied in from that repo's env_vars.yaml. HowToLens contains only
# copied in from that repo's profile_smoke.yaml. HowToLens contains only
# chapter_*/tutorial_*.py, so none of them ever matched a file here.
# Do not copy override patterns between repos; a pattern that matches nothing
# is silently inert, not an override. The list is now empty, and `overrides: []`
Expand Down
Loading