test: genericise repo-name fixtures + add PR-time tenant-firewall gate - #229
Merged
Conversation
Clears the three PyAutoBrain tenant-firewall findings by the recorded decision rule (derivable/arbitrary -> refactor, PyAutoMind#198): - test_worktree_conflict_guard.py: RepoA..RepoG — the awk does plain string compares against no repo list, so real names carried no value. - test_intake_dashboard.py: ExampleOrg — the dashboard regex never inspects the URL owner. - test_profiling_conductor.py: profiling_workspace — every invocation passes --workspace explicitly, which the rename also proves. tests.yml gains the repos_sync.py firewall leg via its new --only selector, so future instance-fact drift fails in the PR that authors it instead of accreting reactive allowlist patches. Note: this step needs the --only selector on PyAutoMind main — merge after the PyAutoMind PR.
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PyAutoBrain leg of PyAutoLabs/PyAutoMind#198 (tenant-firewall drift: refactor-first clear + PR-time gates). Merges after PyAutoLabs/PyAutoMind#199 — the new CI step invokes the
--onlyselector from a PyAutoMind checkout ofmain, so the gate step here stays red until that PR lands (expected; noted in the #198 sequencing comment).Changes
Clears the three PyAutoBrain firewall findings by the recorded decision rule (derivable/arbitrary → refactor, never allowlist):
tests/test_worktree_conflict_guard.py→RepoA…RepoG: the awk inbin/worktree.shdoes plain string compares and validates against no repo list, so real names carried no test value. The docstring's schema examples genericise with it; convention comment added so real names don't creep back.tests/test_intake_dashboard.py→ExampleOrgin the fake issue URLs: the dashboard regex captures whole URLs and never inspects the owner.tests/test_profiling_conductor.py→profiling_workspacefixture dir: every invocation passes--workspaceexplicitly — the rename also proves the override is honoured.Gate (Phase B):
.github/workflows/tests.ymlgains one non-pytest step:repos_sync.py --check --only "tenant firewall (organ code)" --root "$GITHUB_WORKSPACE". The workflow already checks out Brain + Mind side by side — exactly the layout--rootneeds; organs not checked out are skipped by the check, so this gates exactly Brain. Header prose updated (was "deliberately ONLY pytest").Verification
check tenant firewall (organ code): OK, exit 0.Generated by Claude Code