model_mapper does not return PpriorLimitException, but Raises it

[Jammy2211]

In model mapper, this function:

    def assert_within_limits(self, value):
        if not (self.lower_limit <= value <= self.upper_limit):
            raise exc.PriorLimitException(
                "The physical value {} for a prior was not within its limits {}, {}".format(value, self.lower_limit,
                                                                                            self.upper_limit))

Does not return the error. Thus, the error is not used in non_linear to resample a model outside the physical limits :(.

[rhayes777]

This is the correct behaviour

…

On Tue, 27 Nov 2018, 07:58 James Nightingale ***@***.*** wrote: In model mapper, this function: def assert_within_limits(self, value): if not (self.lower_limit <= value <= self.upper_limit): raise exc.PriorLimitException( "The physical value {} for a prior was not within its limits {}, {}".format(value, self.lower_limit, self.upper_limit)) Does not return the error. Thus, the error is not used in non_linear to resample a model outside the physical limits :(. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGETMg84LNJQAhmgr__siVcu8acgLqoEks5uzTbYgaJpZM4Y1b2U> .

[Jammy2211]

When MultiNest runs it doesnt resample points though, it just constantly raises this error.

The other FitExceptions in the code return the errors to ensure that point is not included in the MultiNest samples.

[rhayes777]

0.4.3 resolves this issue. Exceptions raised creating model instances were not being caught so resampling did not occur.