fix: drop stale astropy cap + stale cosmology docstrings - #558
Merged
Conversation
Same floor change as PyAutoArray (astropy>=5.0, cap dropped). Also corrects three stale docstrings in autogalaxy/cosmology/model.py that still described the native xp implementation as wrapping astropy functions. Part of PyAutoLabs/PyAutoArray#434. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sibling of the PyAutoArray astropy-floor PR: drop the stale
<=7.2.0astropy cap, keepingastropy>=5.0(floors, not pins). Also corrects three stale docstrings inautogalaxy/cosmology/model.py: the cosmology is a native xp (NumPy/JAX) implementation, but two methods still claimed to "return only the value of the astropy function it wraps", andcritical_densitycarried a conversational porting note. The accurate astropy parity statements (value-matchingastropy.cosmology) are deliberately kept — they document a real compatibility contract.Part of PyAutoLabs/PyAutoArray#434.
API Changes
None — internal changes only.
Test Plan
pytest test_autogalaxy/— 1027 passed under astropy 8.0.1pip install --dry-runon the sibling PyAutoArray change: resolves astropy 8.0.1 (control on capped main: 7.2.0)ag.Imaging.from_fits+ag.FitImaging) under astropy 8.0.1Full API Changes (for automation & release notes)
None — dependency-metadata change (
pyproject.tomlastropy specifier>=5.0,<=7.2.0→>=5.0) plus docstring-only edits inautogalaxy/cosmology/model.py(no signature or behaviour changes).Generated by the PyAutoLabs agent workflow.