Support Yang+2024 SIDM profiles in substructure halo batching - #691
Merged
Conversation
Extends the substructure halo-parameter extractor to YangSIDMSph and YangSIDMMCRLudlowSph, packing the evolved (rho_s, r_s, r_c) so subhalo and line-of-sight halo populations can use the Yang+2024 gravothermal profile on the vmapped multi-plane tracing path. Per-plane halo ages enter through each profile's own t_age at construction. Requested in #631; companion to PyAutoGalaxy#556. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to PyAutoLabs/PyAutoGalaxy#556 (requested in #631): lets subhalo and line-of-sight halo populations use the Yang, Nadler, Yu & Zhong (2024) parametric SIDM gravothermal profile on the vmapped multi-plane substructure-tracing path. The halo-parameter extractor packs the evolved (rho_s, r_s, r_c) of each halo, so tau is resolved per halo at construction — including per-redshift-plane halo ages via each profile's t_age.
API Changes
None — internal changes only. The private
_halo_parameter_extractor_fromgains a branch for the new Yang profile classes (guarded with getattr, so PyAutoLens still works against a released PyAutoGalaxy without them).See full details below.
Test Plan
test_autolens/lens/test_substructure_util.py— new tests:al.mpexposes both Yang classes;galaxies_to_halo_arrayspacks (centre, rho_s_evolved, scale_radius_evolved, core_radius_evolved) with correct shapes/masks (jax).test_autolens/suite: 512 passed.Full API Changes (for automation & release notes)
Changed Behaviour
autolens.lens.substructure_util._halo_parameter_extractor_from(private) now supportsag.mp.YangSIDMSphandag.mp.YangSIDMMCRLudlowSph(5 packed parameters), alongside the existing cNFW, Kaplinghat and truncated-NFW classes.Migration
Generated by the PyAutoLabs agent workflow.