Skip to content

refactor: lazy astropy + workspace version-warning dedupe #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
Aug 19, 2026
+23 −9
Merged

refactor: lazy astropy + workspace version-warning dedupe #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions autonerves/fitsable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@
except ImportError:
pass

try:
from astropy.io import fits
except ImportError:
pass

import numpy as np
from pathlib import Path
from typing import Dict, Optional, Union, List
Expand Down Expand Up @@ -58,8 +53,10 @@ def hdu_list_for_output_from(
ext_name_list=["data", "noise_map"]
)
"""
from astropy.io import fits

hdu_list = []

header = fits.Header()

if header_dict is not None:
Expand Down Expand Up @@ -207,6 +204,8 @@ def ndarray_via_fits_from(
--------
array_2d = ndarray_via_fits_from(file_path='/path/to/file/filename.fits', hdu=0)
"""
from astropy.io import fits

with fits.open(
file_path, do_not_scale_image_data=do_not_scale_image_data
) as hdu_list:
Expand Down Expand Up @@ -235,6 +234,8 @@ def header_obj_from(file_path: Union[Path, str], hdu: int) -> Dict:
--------
array_2d = ndarray_via_fits_from(file_path='/path/to/file/filename.fits', hdu=0)
"""
from astropy.io import fits

with fits.open(file_path) as hdu_list:
return hdu_list[hdu].header

Expand Down
19 changes: 16 additions & 3 deletions autonerves/workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,19 @@ class WorkspaceVersionMismatchError(exc.ConfigException):
# enough to suggest the clone is genuinely stale.
_STALENESS_WINDOW_DAYS = 30

# Every library init (autofit, autogalaxy, autolens, ...) calls check_version,
# so without dedup a byte-identical warning prints once per library in the
# import chain. Python's own warning registry does not dedupe here because
# third-party imports between the calls invalidate it.
_warned_messages = set()


def _warn_once(message):
if message in _warned_messages:
return
_warned_messages.add(message)
warnings.warn(message)


def _read_general_yaml(workspace_root):
"""
Expand Down Expand Up @@ -224,7 +237,7 @@ def check_version(library_version, workspace_root=None):
if floor_version is None or floor_version == "":
if _is_source_checkout(root):
return
warnings.warn(_missing_version_warning(root, library_version))
_warn_once(_missing_version_warning(root, library_version))
return

if floor_version == library_version:
Expand All @@ -234,7 +247,7 @@ def check_version(library_version, workspace_root=None):
library_parsed = _parse_version(library_version)

if floor_parsed is None or library_parsed is None:
warnings.warn(
_warn_once(
_unparseable_mismatch_message(floor_version, library_version, root)
)
return
Expand All @@ -252,4 +265,4 @@ def check_version(library_version, workspace_root=None):
and library_date is not None
and (library_date - floor_date).days > _STALENESS_WINDOW_DAYS
):
warnings.warn(_stale_workspace_message(floor_version, library_version, root))
_warn_once(_stale_workspace_message(floor_version, library_version, root))
Loading