MicroPython/CircuitPython compatibility and CPython 3.12 fixes - #10
Merged
Conversation
- Use positional super().__init__ and child Widget calls (MCU keyword limits) - Re-export pct submodule for widgets_percent - Import ClippedCanvas from graphics with _clip fallback - Replace contextlib.suppress with try/except in spinner/toast - Simplify add_event_cb signature (no forward-ref type hint) Paired with pydisplay PR #78 example matrix validation.
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores pydisplay example matrix compatibility after pdwidgets moved to its own repo.
Fixes
super().__init__(...)and internalWidget/Icon/Labelconstructor calls with positional args (TypeError: function doesn't take keyword arguments).Widget.add_event_cbsignature (no forward-refWidget | Noneannotation evaluated at class body scope).widgets_percent— re-exportpctfrompdwidgets/__init__.py(from pdwidgets import pct).ClippedCanvasfromgraphicswithgraphics._clipfallback.contextlib.suppressin spinner/toast with try/except.Testing
With pydisplay siblings on path and patches applied, 22/22 palettes+pdwidgets examples pass on CPython and MicroPython (see pydisplay#78).