Revert back to emulate ZipExtFile.seek#111
Merged
willmcgugan merged 3 commits intoPyFilesystem:masterfrom Nov 15, 2017
althonos:fix-zipfs
Merged
Revert back to emulate ZipExtFile.seek#111willmcgugan merged 3 commits intoPyFilesystem:masterfrom althonos:fix-zipfs
ZipExtFile.seek#111willmcgugan merged 3 commits intoPyFilesystem:masterfrom
althonos:fix-zipfs
Conversation
Member
|
Fair enough. Using the buffer was clever, but obviously complicated things considerably. I imagine the 99% use case would be to read the entire file sequentially anyway. |
Member
Author
|
Yes, the ZIP format does not support random access anyway, so in the end the best practice would be either to read it sequentially or to decompress the archive. |
Member
|
Thanks. I'll do a release shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the lower level interface is:
This PR reverts back to a purely emulated seeking feature, i.e. seeking forward by reading.