Skip to content

[Rebase] Add support for Check Suites#1764

Merged
s-t-e-v-e-n-k merged 17 commits intoPyGithub:masterfrom
dhruvmanila:feature/checksuite
Nov 30, 2020
Merged

[Rebase] Add support for Check Suites#1764
s-t-e-v-e-n-k merged 17 commits intoPyGithub:masterfrom
dhruvmanila:feature/checksuite

Conversation

@dhruvmanila
Copy link
Copy Markdown
Contributor

Continuing on the work done by @wrecker in #1646

As mentioned in the latest review: #1646 (review)

  • Properties are 'type' not 'rtype'
  • This actually calls a URL, so this needs more detail.
  • Fixed merge conflicts.

NOTE: I will add other CheckSuite API endpoints in a couple of days.

@sbesson Should the other endpoints be included in this PR and thus, in the next release?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 25, 2020

Codecov Report

Merging #1764 (2455455) into master (197e065) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1764   +/-   ##
=======================================
  Coverage   98.75%   98.76%           
=======================================
  Files          50       51    +1     
  Lines        2660     2677   +17     
=======================================
+ Hits         2627     2644   +17     
  Misses         33       33           
Impacted Files Coverage Δ
github/RepositoryPreferences.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197e065...2455455. Read the comment docs.

@sfdye sfdye requested a review from s-t-e-v-e-n-k November 25, 2020 14:18
@dhruvmanila
Copy link
Copy Markdown
Contributor Author

It also seems that the Checks API graduated from their preview period. I shall remove the preview headers soon.

@sbesson
Copy link
Copy Markdown
Contributor

sbesson commented Nov 25, 2020

@dhruvmanila thanks for doing this, I have quickly tested this PR in the context of our library and at least I can confirm all the check suites endpoints we would need on our side are present and functional. 💯

As per the other endpoints, I think you referred to list check runs in a check suite in the previous PR which makes sense. Is there anything else?

@dhruvmanila
Copy link
Copy Markdown
Contributor Author

This one creates a check suite and this one updates repository preferences for check suites and the last one you mentioned.

By default, GitHub automatically creates a check suite each time code is pushed to a repository, changing the preferences for each app allows you to be in control of when you want the check suite to be created. I don't know where this could be useful.

Copy link
Copy Markdown
Collaborator

@s-t-e-v-e-n-k s-t-e-v-e-n-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make certain that you attribute @wrecker in your commit if you haven't. I have some concerns which I've highlighted inline, but other than that, thanks for addressing my comments from the previous PR.

@dhruvmanila
Copy link
Copy Markdown
Contributor Author

I pulled down the commits made by @wrecker and rebased it on the latest upstream. So, all the commits still attribute @wrecker as their author. The three commits made by @wrecker in this pull request:

@dhruvmanila dhruvmanila changed the title [Rebase] Add initial support for Check Suites [Rebase] Add support for Check Suites Nov 27, 2020
@dhruvmanila
Copy link
Copy Markdown
Contributor Author

@s-t-e-v-e-n-k @sbesson All endpoints have been added, please take a look at the new changes made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants