[Rebase] Add support for Check Suites#1764
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1764 +/- ##
=======================================
Coverage 98.75% 98.76%
=======================================
Files 50 51 +1
Lines 2660 2677 +17
=======================================
+ Hits 2627 2644 +17
Misses 33 33
Continue to review full report at Codecov.
|
|
It also seems that the Checks API graduated from their preview period. I shall remove the preview headers soon. |
|
@dhruvmanila thanks for doing this, I have quickly tested this PR in the context of our library and at least I can confirm all the check suites endpoints we would need on our side are present and functional. 💯 As per the other endpoints, I think you referred to list check runs in a check suite in the previous PR which makes sense. Is there anything else? |
|
This one creates a check suite and this one updates repository preferences for check suites and the last one you mentioned. By default, GitHub automatically creates a check suite each time code is pushed to a repository, changing the preferences for each app allows you to be in control of when you want the check suite to be created. I don't know where this could be useful. |
s-t-e-v-e-n-k
left a comment
There was a problem hiding this comment.
Make certain that you attribute @wrecker in your commit if you haven't. I have some concerns which I've highlighted inline, but other than that, thanks for addressing my comments from the previous PR.
9aaabe3 to
c8538aa
Compare
|
@s-t-e-v-e-n-k @sbesson All endpoints have been added, please take a look at the new changes made. |
Continuing on the work done by @wrecker in #1646
As mentioned in the latest review: #1646 (review)
NOTE: I will add other CheckSuite API endpoints in a couple of days.
@sbesson Should the other endpoints be included in this PR and thus, in the next release?