-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Drop Reaction.delete method #3436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3436 +/- ##
==========================================
+ Coverage 97.00% 97.04% +0.04%
==========================================
Files 172 176 +4
Lines 18934 19752 +818
==========================================
+ Hits 18366 19169 +803
- Misses 568 583 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Test Results 8 files ±0 8 suites ±0 2m 44s ⏱️ -1s Results for commit 8d17054. ± Comparison against base commit f2540db. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
EnricoMi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete the replay data file as well:
https://github.com/PyGithub/PyGithub/blob/main/tests/ReplayData/Reaction.testDelete.txt
EnricoMi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I have turned this into a draft, to postpone the merge for a while (at least after the 2.9.0 or 3.0.0 release). |
As discussed in #3434 . The endpoint no longer exists in public GitHub.