Adding unit test for tree attribute of GitCommit#668
Merged
jasonwhite merged 2 commits intoPyGithub:masterfrom Dec 10, 2017
Merged
Adding unit test for tree attribute of GitCommit#668jasonwhite merged 2 commits intoPyGithub:masterfrom
jasonwhite merged 2 commits intoPyGithub:masterfrom
Conversation
jasonwhite
reviewed
Dec 8, 2017
github/Commit.py
Outdated
| if "url" in attributes: # pragma no branch | ||
| self._url = self._makeStringAttribute(attributes["url"]) | ||
| if "tree" in attributes: # pragma no branch | ||
| self._tree = self._makeClassAttribute(Commit, attributes["tree"]) |
Collaborator
There was a problem hiding this comment.
This doesn't really make sense. The tree is not a commit. The JSON also doesn't quite provide enough information to construct a GitTree object either (it's missing the subtree elements).
It might make more sense to expose a property called tree_sha instead. Then, it could be used in conjunction with Repository.get_git_tree().
Member
Author
There was a problem hiding this comment.
Seems like I was confusing the Commit with GitCommit, actually the tree attribute is already. So I will just add the missing unit test for this PR.
sfdye
changed the title
sfdye
changed the title
Member
Author
|
@jasonwhite how about now? |
jasonwhite
approved these changes
Dec 10, 2017
Collaborator
jasonwhite
left a comment
jasonwhite
left a comment
There was a problem hiding this comment.
Looks good. I had forgotten about the commit attribute. This makes more sense. Thanks!
Member
Author
|
Thanks for pointing out my mistake earlier 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a simple unit test for tree attribute for GitCommit.