feat(web): quieten the sidebar session rows - #111
Closed
elkaix wants to merge 1 commit into
Closed
Conversation
The rows hovered with a solid `--panel2` and marked selection with a solid `--soft`, which is the opposite of the two idioms the rest of the UI now follows: a translucent hover, and a barely-there active state. Hover moves to `--hover`, selection to the same faint wash the shared menu row uses, and the radius to `--r-md`. Row and title sizes derive from `--ui-font-size` so the font-size setting still scales them, and the section labels drop to the muted tone. The per-theme overrides in `style.css` carried their own solid colours, so they are updated too — changing only the scoped block would have left two of the three themes unchanged. The row height is a minimum, not a fixed height: the row also carries an 18px tag pill and the archive-confirm strip, both of which a fixed height clips.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
commit: |
5 tasks
Member
Author
|
Closing: merged locally into main; a new PR will follow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No issue. The problem is described below.
Problem
The sidebar session rows do the opposite of the two idioms the rest of the UI now follows. They hover with a solid
var(--panel2)fill and mark the selected row with a solidvar(--soft)fill, at an 8px radius with a pinned text size.What changed
--hovertoken — the translucent washstyle.cssalready describes for exactly this purpose.color-mixwash the sharedMenuRowprimitive uses, so the sidebar and the menus agree.--r-md, and the row and title sizes derive from--ui-font-sizeso the font-size setting still scales them. Section labels drop to the muted tone.Behaviour is unchanged.
Three things worth calling out:
style.csscarried its own per-theme overrides for these rows, with their own solid colours. Changing only the scoped block would have left themodernandpythinkerthemes untouched — the change would have looked correct in the default theme and been invisible in the other two. Those overrides are updated as well, and a test now pins them.min-heightand fails if it becomes a fixedheight.git show HEAD. That baseline compares the file to itself once the change lands, so it could never fail again, and it required git at test time. It is now an explicit allowlist of the one pre-existing literal.Deliberately not included: the sidebar resizer and the chat header.
App.vuealready has a persisted drag resizer viaResizeHandle/useResizable(270px default, clamped 170–420) — rewriting it to different numbers is churn. The header's fixed 48px is coupled to the desktop title-bar reserve asserted inwindows-titlebar.test.ts, so restyling it belongs in its own change.Verified locally: 346 web tests, typecheck and lint all pass, and the suite passes again after the pre-commit autofix. Both new guards were mutation-checked.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.