fix(desktop): complete the update restart flow - #126
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe desktop update prompt now uses one Update action. The updater downloads available releases, installs them after download completion, closes the application, and restarts it. Tests and desktop documentation cover the new flow. ChangesDesktop update flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR completes the desktop update restart flow and adds focused regression coverage; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
commit: |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @pymodel/pythinker-code@0.21.2 ### Patch Changes - [#126](#126) [`a447a2c`](a447a2c) - Fix desktop update prompts so one action downloads, closes, installs, and restarts the app. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Related Issue
No issue. This bug was reported directly with macOS screenshots and a reproducible update failure.
Problem
The update restart closed Electron windows before the normal quit event. The tray close handler hid the window, and the bundled local server remained active. macOS ShipIt then found two running Pythinker processes and canceled the installation. The remaining app could show a main-process connection error.
What changed
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Summary by CodeRabbit
Bug Fixes
Documentation