Skip to content

test: sequence the advisor mock with ordered handlers #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elkaix merged 1 commit into from
Aug 12, 2026
+13 −9
Merged

test: sequence the advisor mock with ordered handlers #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions packages/agent-core/test/session/session-advisor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,19 @@ describe('SessionAdvisor', () => {
const reviewGate = createDeferred<void>();
const activeTurnGate = createDeferred<void>();
const generate = fixture.main.rawGenerate;
let generateCall = 0;
vi.spyOn(fixture.main, 'rawGenerate').mockImplementation(async (...args) => {
generateCall += 1;
const currentCall = generateCall;
const result = await generate(...args);
if (currentCall === 2) await reviewGate.promise;
if (currentCall === 3) await activeTurnGate.promise;
return result;
});
vi.spyOn(fixture.main, 'rawGenerate')
.mockImplementationOnce(generate)
.mockImplementationOnce(async (...args) => {
const result = await generate(...args);
await reviewGate.promise;
return result;
})
.mockImplementationOnce(async (...args) => {
const result = await generate(...args);
await activeTurnGate.promise;
return result;
})
.mockImplementation(generate);
const steer = vi.spyOn(fixture.main.turn, 'steer').mockReturnValue(null);
queueReview(fixture.scripted, 'Check the active turn.', 'concern');

Expand Down
Loading