optimize: improve logging when performing rolling horizon#695
Merged
FabianHofmann merged 3 commits intomasterfrom Jul 25, 2023
Merged
optimize: improve logging when performing rolling horizon#695FabianHofmann merged 3 commits intomasterfrom
FabianHofmann merged 3 commits intomasterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #695 +/- ##
==========================================
- Coverage 78.14% 78.12% -0.02%
==========================================
Files 26 26
Lines 6764 6767 +3
Branches 1467 1468 +1
==========================================
+ Hits 5286 5287 +1
- Misses 1165 1166 +1
- Partials 313 314 +1
☔ View full report in Codecov by Sentry. |
fneum
approved these changes
Jul 25, 2023
Member
fneum
left a comment
There was a problem hiding this comment.
Just one small suggestion. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a rolling horizon, the logging was a bit poor before, this makes it better
Checklist
doc.environment.yaml,environment_docs.yamlandsetup.py(if applicable).doc/release_notes.rstof the upcoming release is included.