Skip to content

optimize: improve logging when performing rolling horizon#695

Merged
FabianHofmann merged 3 commits intomasterfrom
optimize-rolling-horizon
Jul 25, 2023
Merged

optimize: improve logging when performing rolling horizon#695
FabianHofmann merged 3 commits intomasterfrom
optimize-rolling-horizon

Conversation

@FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented Jul 25, 2023

When running a rolling horizon, the logging was a bit poor before, this makes it better

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@FabianHofmann FabianHofmann requested a review from fneum July 25, 2023 07:23
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.02% ⚠️

Comparison is base (14cef6b) 78.14% compared to head (3d3428f) 78.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
- Coverage   78.14%   78.12%   -0.02%     
==========================================
  Files          26       26              
  Lines        6764     6767       +3     
  Branches     1467     1468       +1     
==========================================
+ Hits         5286     5287       +1     
- Misses       1165     1166       +1     
- Partials      313      314       +1     
Files Changed Coverage Δ
pypsa/optimization/optimize.py 87.08% <ø> (ø)
pypsa/optimization/abstract.py 46.34% <62.50%> (-0.25%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants