Skip to content

repair CI#726

Merged
fneum merged 2 commits intoPyPSA:masterfrom
pz-max:ci
Sep 10, 2023
Merged

repair CI#726
fneum merged 2 commits intoPyPSA:masterfrom
pz-max:ci

Conversation

@pz-max
Copy link
Contributor

@pz-max pz-max commented Sep 9, 2023

Changes proposed in this Pull Request

Build on PR #724 but adding pandas constraint.
We probably have to delve into the pandas warning to use the newer pandas versions:

FutureWarning: Setting an item of incompatible dtype is deprecated and will raise in a future error of pandas.
Value '[-1.34291453e-13 -9.58966072e-14]' has dtype incompatible with int64,
please explicitly cast to a compatible dtype first.
    network.buses_t.p.loc[snapshots, sn_buses] = s_calc.real[

Collab with @drifter089 on this PR.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • I consent to the release of this PR's code under the MIT license.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a0027f5) 78.00% compared to head (7171725) 78.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #726   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files          26       26           
  Lines        6788     6788           
  Branches     1474     1474           
=======================================
  Hits         5295     5295           
  Misses       1176     1176           
  Partials      317      317           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a fix since constraining pandas version, but temporary solution.

@fneum fneum merged commit dfb430c into PyPSA:master Sep 10, 2023
@fneum fneum mentioned this pull request Sep 10, 2023
@pz-max pz-max deleted the ci branch September 11, 2023 14:39
@maurerle
Copy link
Contributor

maurerle commented Feb 5, 2024

Is this still needed? @pz-max
For python 3.12 the first pyomo release supported is 6.7 which is not installable with the latest pypsa version 0.26.3 - due to the pyomo version limit.

This results in conda installing an older pypsa version (0.25.1) which is unsupported in other ways (pd.Dataframe does not have .map and other things..)

So it would be good to have a pypsa release which supports pyomo 6.7 😊

@fneum
Copy link
Member

fneum commented Feb 5, 2024

I agree. Support for Pyomo 6.7 would be good. We're happy to receive a PR that restores compatibility, but our current plan is to phase out maintenance of the pyomo backend in favour of linopy and eventually remove it completely.

@nick-harder nick-harder mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants