Set cache_ok=True on remaining custom TypeDecorators - #97
Merged
Conversation
PathString, RevisionStateString, OperationString, TaskStateString and IngestionJobStateString lacked cache_ok, so SQLAlchemy could not cache the compiled statement for any query touching those columns — emitting a SAWarning and recompiling on every execution (surfaced by get_dataset_summary_map, which selects revision.state). They are stateless decorators (fixed impl, no params affecting SQL), so caching is safe, matching DatasetStateString/TZDateTime. Claude-Session: https://claude.ai/code/session_01B5EfLJqoafjW1FhvkxGSmg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.