Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3334/head:pr-3334
git checkout pr-3334This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3334/head |
vmphase
commented
Aug 7, 2026
Comment on lines
+172
to
+178
| except BaseException: | ||
| _log.exception( | ||
| "An error occurred while stopping the gateway. Ignoring." | ||
| ) | ||
| finally: | ||
| self.stop() | ||
| return | ||
| return |
Member
Author
There was a problem hiding this comment.
For anyone interested why Exception was changed to BaseException: previously, a non-Exception failure from f.result() (e.g. SystemExit) wasn't caught here, so it fell into finally, where the return silently discarded it. Now it's explicitly caught and logged instead with same end result.
Lulalaby
approved these changes
Aug 7, 2026
Paillat-dev
approved these changes
Aug 7, 2026
Member
Author
ToothyDev
approved these changes
Aug 7, 2026
Paillat-dev
enabled auto-merge (squash)
August 7, 2026 09:33
Lulalaby
disabled auto-merge
August 7, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
This PR fixes #3332:
SyntaxWarning: 'return' in a 'finally' block(introduced in Python 3.14) in two places (ruffB012)Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.