Honor tags added to block_level_elements after md_in_html loads - #1629
Open
gyanu2507 wants to merge 1 commit into
Open
Honor tags added to block_level_elements after md_in_html loads#1629gyanu2507 wants to merge 1 commit into
gyanu2507 wants to merge 1 commit into
Conversation
The extension copied Markdown.block_level_elements at init, so md.block_level_elements.append() after construction was ignored. Read the live list instead. Fixes Python-Markdown#1246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
md_in_htmlcopiedMarkdown.block_level_elementswhen the extractor was constructed. Tags registered later withmd.block_level_elements.append('a-b')were therefore ignored, so custom elements never got block-level treatment ormarkdown="1"parsing.The extractor now reads the live list. That is the change discussed in #1246 (not treating every hyphenated name as a block tag).
Test plan
python3 -m unittest tests.test_syntax.extensions.test_md_in_html(198 tests)Fixes #1246