Skip to content

fix: show docked Q10 robot on map#904

Draft
tubededentifrice wants to merge 3 commits into
Python-roborock:mainfrom
tubededentifrice:vc/q10-docked-state
Draft

fix: show docked Q10 robot on map#904
tubededentifrice wants to merge 3 commits into
Python-roborock:mainfrom
tubededentifrice:vc/q10-docked-state

Conversation

@tubededentifrice

@tubededentifrice tubededentifrice commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Final rendering slice extracted from #900, stacked on #903. The Q10 map trait now combines status with map packets so a docked robot is still rendered after its live trace disappears.

Changes

  • declare StatusTrait as an explicit map-trait dependency
  • use named dock-state enum values for charging and emptying
  • clear stale and late trace packets when the robot is docked
  • render the docked robot at the saved dock position
  • publish one coherent map update when a DPS packet changes both map and status
  • test the combined behavior through the public subscription queue

Before / after

These are the real Home Assistant map-card captures from #900.

Before After
Before: Q10 map without the docked robot state After: docked Q10 robot rendered at the saved dock position

Validation

  • pytest -q — 892 passed, 86 snapshots passed
  • pre-commit run --files ... — all hooks passed

Stack / review order

  1. feat: align Q10 map colors with V1 #902 — base raster and room palette
  2. refactor: render Q10 overlays with V1 #903 — V1 overlay renderer
  3. This PR: docked-state composition

GitHub cannot target an upstream PR at a branch that exists only in a fork, so
this PR temporarily targets main and includes #902 and #903 in
Files changed. The independent incremental diff is:

tubededentifrice/python-roborock@vc/q10-v1-overlays...vc/q10-docked-state

After its parents merge, this PR can be rebased onto main without changing its review boundary. The transport correction is independent in #901; #900 remains the aggregate full before-and-after reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant