Skip to content

Rearrange the order of the Asset Identifier section in ZIP 227#104

Merged
vivek-arte merged 5 commits intomainfrom
rearrange_zip_227
May 23, 2025
Merged

Rearrange the order of the Asset Identifier section in ZIP 227#104
vivek-arte merged 5 commits intomainfrom
rearrange_zip_227

Conversation

@vivek-arte
Copy link

@vivek-arte vivek-arte commented Apr 22, 2025

This PR rearranges the parts specifying the Asset Identifier, Asset Digest and Asset Base in ZIP 227. The aim is to make the specification more linear for ease of reading. It also adds an additional figure to help explain the structure of the derivations.

This branch also is a pull request to upstream (zcash#1009).

@netlify
Copy link

netlify bot commented Apr 22, 2025

Deploy Preview for zcash-zips-qedit ready!

Name Link
🔨 Latest commit c3d0d07
🔍 Latest deploy log https://app.netlify.com/sites/zcash-zips-qedit/deploys/681877cb6b01820008b6e736
😎 Deploy Preview https://deploy-preview-104--zcash-zips-qedit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is impressive.
One thing, in the new drawing please add the fixed sizes for ik[u8; 32] and assetDescHash[u8; 32].
And also for AssetID, AssetDigest and AssetBase
(verify the sizes plz)

Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asset_digest is 64B, no?

@vivek-arte vivek-arte force-pushed the rearrange_zip_227 branch from 366971a to c3d0d07 Compare May 5, 2025 08:33
@vivek-arte vivek-arte merged commit 44435a0 into main May 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants