-
Notifications
You must be signed in to change notification settings - Fork 158
Remove native-gates file; update get-qpu-information, qpu-information, and processor-types accordingly #3613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I'm going to raise my objection again about hard coding native gate set, especially since the page says
and here we are, changing it 🙂. Also if you run the Qiskit code from that page, or view on IQP, you will not find If we don't want to remove the page, my suggestion would be to
|
|
Leron is in favor of pulling this page - redirect to processor-types. We need to look at the native gates listed on that page for updates |
|
I didn't realize the processor type page also has native gates and operations hard coded 😅. So that page will need to be updated as well. I think some information from the native gate page is worth preserving, if the decision is to pull it:
|
| "```\n", | ||
| "\n", | ||
| "<span id=\"native-gates-on-platform\"></span>\n", | ||
| "### On IBM Quantum Platform\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyu00 Should I skip bringing over the info on how to find supported gates on the Platform, since this page is specific to Qiskit? I guess I could move this piece to the QPU information page?.... thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the preview for more context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it should be moved to QPU information page, especially since these two are actually different - one shows non-unitary operations and the other doesn't.
Interesting that the Additional information available on the details page for each QPU section on the QPU information page doesn't already talk about basis gates, even though it's on the details page.
I don't want to derail this PR further, but the separation of this page and the "QPU information" page is not very clear to me. The latter appears to be the compute resources page on the Platform, but it also mentions Qiskit. And the two pages have some duplicated data... maybe something to consider in a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I almost typed the same thing yesterday! - I find it very confusing that we have two such similarly-named pages. I'll open a new issue to consider this after this PR is done
|
@jyu00 I am removing if_else from the list of native gates, unless you expect it to come back in future public backends? |
|
Last question (for now) @jyu00 - I'm guessing you'd prefer not to hard-code the native gates on the processor-types page either! - so should we point to the new |
|
One or more of the following people are relevant to this code:
|
|
Thanks @jyu00! I think I've addressed all your feedback - do you see anything I've missed? |
jyu00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on IQP terminology but otherwise looks good!
docs/guides/qpu-information.mdx
Outdated
| <Admonition type="note" title="Native gates and basis gates"> | ||
| The terms native gates and basis gates are often used interchangeably. The native gates are those that calibrations have been done for on the QPU, so the QPU can understand and execute them without further instruction. However, you can pass a subset of the native gates as the basis gates to the transpiler. For information about changing the basis gates, see the [Represent quantum computers](/docs/guides/represent-quantum-computers#basis-gates) topic. | ||
| </Admonition> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just delete this, since the basis gates listed on IQP are actually native gates (i.e. you can't change them).
| "<Admonition type=\"note\" title=\"Native gates and basis gates\">\n", | ||
| "The terms native gates and basis gates are often used interchangeably. The native gates are those that calibrations have been done for on the QPU, so the QPU can understand and execute them without further instruction. However, you can pass a subset of the native gates as the basis gates to the transpiler. For information about changing the basis gates, see the [Represent quantum computers](/docs/guides/represent-quantum-computers#basis-gates) topic.\n", | ||
| "</Admonition>\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing the QPU information section, I think we should just delete this. This paragraph was more useful when you could add custom gates via pulse gates... but that's no longer supported. It's now confusing to have these as separate terms since IQP uses basis gates to mean native gates.
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Closes #3070
@jyu00 I am removing for_loop and switch_case from Heron. Where should the
fractional gateslink point - the page in the guides, or somewhere in the API (like the rest of the table)? Also, anything to put in the notes field?