uPnPEnabled toggle + capability-only transport selection - #16
Merged
Conversation
- Add uPnPEnabled (Core 1.6.3+) to the editable settings so the new UPnP toggle is switchable from the settings page; older Cores without it in writable metadata keep it read-only. - Collapse the allowedTransports dropdown from four ordered options to a capability set (IP only / IP + I2P / I2P only). Core treats transport order as a soft preference with reserved dial slots since core PR #191, and the ordering choice only created a Dashboard-vs-Settings mismatch with Home. The legacy ['I2P','IP'] value still displays as IP + I2P. - Version 1.4.4. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
uPnPEnabledjoins the editable settings (boolean, default on). Core 1.6.3 added it to the writable-settings allowlist (restartRequired); on older Cores it stays read-only because it is missing from the writable metadata.IP only/IP + I2P/I2P only, dropping theI2P + IPordering variant. Core treats transport order as a soft preference with reserved outbound slots for the other transport since fix(net): give both transports a fair share of connections qortium-core#191, so the ordering choice no longer changes behaviour enough to justify the confusion — and it was the source of the Dashboard-vs-Settings mismatch Bebop reported (Home's dashboard select is capability-only and displayed the ordered['I2P','IP']state as plainIP + I2P).['I2P','IP']showsIP + I2P; nothing is written unless the user changes the control (pickingIP + I2Pthen writes['IP','I2P']).Testing
vitest run: 39/39 passing, including new cases for the order-insensitive selection mapping, retired-option fallback, uPnPEnabled defaults/editability/restart-required detection, and its position in the settings group ordering.npm run build(tsc + vite) clean.GET /admin/settings/metadatareportsuPnPEnabledasBOOLEAN, restartRequired=true.🤖 Generated with Claude Code