Skip to content

Feature/notebooks examples#243

Merged
Zochory merged 4 commits intomainfrom
feature/notebooks-examples
Oct 19, 2025
Merged

Feature/notebooks examples#243
Zochory merged 4 commits intomainfrom
feature/notebooks-examples

Conversation

@Zochory
Copy link
Member

@Zochory Zochory commented Oct 19, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test updates
  • Configuration change

Related Issues

Fixes #

Changes Made

  • (describe your changes here)

Testing

  • All existing tests pass (uv run pytest)
  • Added new tests for new functionality
  • Configuration validation passes (uv run python tests/test_config.py)
  • Linting passes (uv run ruff check .)
  • Formatting is correct (uv run black .)
  • Type checking passes (uv run mypy .)

Test Commands Run

# Commands run to validate changes
uv run pytest
uv run python tests/test_config.py
uv run ruff check .
uv run black .

Documentation

  • Updated relevant documentation
  • Added docstrings to new functions/classes
  • Updated README if needed
  • Updated CHANGELOG if needed

Screenshots (if applicable)

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Notes

…ew features

- Add agent_as_workflow.ipynb: Demonstrates WorkflowAgent pattern with reflection and retry
- Update azure_responses_client.ipynb: Azure OpenAI Responses Client with function calling
- Update openai_responses_example.ipynb: OpenAI Responses Client direct usage examples
- Update mem0_basic.ipynb: Mem0 provider integration for long-term memory
- Update magentic.ipynb: Complete Magentic orchestration with multi-agent coordination
- Update yaml_workflow.ipynb: YAML-based workflow configuration and execution
- Clear all output cells to keep notebooks clean

Resolves #220 and #221
Add frontend-install, dev, haxui-server, frontend-dev and test-e2e targets to the Makefile
and include them in .PHONY. Update the help output to document the new commands. Implement
frontend-install (runs npm install), dev (starts backend + frontend concurrently), dedicated
backend/frontend dev targets, and a test-e2e target to run the Playwright workflow. Tweak
install target output messaging for clarity.
…ckfile

- Update pyproject.toml version to 0.5.3
- Regenerate uv.lock: update agent-framework-core version, bump openai to 2.5.0
- Add/record runtime deps for ipykernel, azure-ai-evaluation, tiktoken and their transitive dependencies
- Add many new lock entries and wheels as part of dependency resolution
Signed-off-by: Zachary BENSALEM <zachary@qredence.ai>
@github-actions github-actions bot added the dependencies Dependency updates label Oct 19, 2025
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
pip/azure-ai-evaluation >= 1.12.0 🟢 6.1
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 1030 commit(s) and 7 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices🟢 5badge detected: Passing
License🟢 10license file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Security-Policy🟢 10security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Signed-Releases⚠️ -1no releases found
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts🟢 8binaries present in source code
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing🟢 10project is fuzzed
Vulnerabilities⚠️ 091 existing vulnerabilities detected
pip/ipykernel >= 7.0.1 🟢 5.2
Details
CheckScoreReason
Code-Review⚠️ 2Found 7/28 approved changesets -- score normalized to 2
Maintained🟢 1025 commit(s) and 12 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Vulnerabilities🟢 100 existing vulnerabilities detected
Fuzzing🟢 10project is fuzzed
License🟢 10license file detected
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
Security-Policy⚠️ 0security policy file not detected
Branch-Protection⚠️ -1internal error: error during GetBranch(6.x): error during branchesHandler.query: internal error: githubv4.Query: Resource not accessible by integration
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
pip/openai 2.5.0 🟢 6.2
Details
CheckScoreReason
Security-Policy🟢 10security policy file detected
Maintained🟢 1030 commit(s) and 8 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Code-Review⚠️ -1Found no human activity in the last 10 changesets
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Vulnerabilities🟢 100 existing vulnerabilities detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
pip/tiktoken >= 0.12.0 🟢 5.1
Details
CheckScoreReason
Code-Review🟢 3Found 9/30 approved changesets -- score normalized to 3
Packaging⚠️ -1packaging workflow not detected
Binary-Artifacts🟢 10no binaries found in the repo
Maintained🟢 109 commit(s) and 15 issue activity found in the last 90 days -- score normalized to 10
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy⚠️ 0security policy file not detected
Vulnerabilities🟢 100 existing vulnerabilities detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • pyproject.toml

@github-project-automation github-project-automation bot moved this to Backlog in AgenticFleet Oct 19, 2025
@Zochory Zochory marked this pull request as ready for review October 19, 2025 19:19
Copilot AI review requested due to automatic review settings October 19, 2025 19:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds notebook and evaluation related Python dependencies and introduces frontend development and E2E test targets to the Makefile, preparing for notebook examples and a full-stack dev workflow.

  • Bumps project version to 0.5.3 while adding new runtime dependencies (ipykernel, openai, azure-ai-evaluation, tiktoken).
  • Expands Makefile with frontend install/run targets and an end-to-end test runner.
  • Removes direct ad-hoc installation of openai in favor of pyproject-managed dependency.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
pyproject.toml Version bump and addition of four new dependencies to support notebooks/evaluation.
Makefile Adds frontend/dev orchestration targets and E2E test command; adjusts install messaging.

[project]
name = "agentic-fleet"
version = "0.5.2"
version = "0.5.3"
Copy link

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Adding new user-facing dependencies alters the install surface and is more than a patch-level change; consider bumping the minor version (e.g., 0.6.0) per semantic versioning rather than a patch increment.

Suggested change
version = "0.5.3"
version = "0.6.0"

Copilot uses AI. Check for mistakes.
Comment on lines +40 to +43
"ipykernel>=7.0.1",
"openai==2.5.0",
"azure-ai-evaluation>=1.12.0",
"tiktoken>=0.12.0",
Copy link

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] ipykernel is only needed for notebook/examples usage; placing it in core dependencies forces all installations to pull Jupyter stack. Recommend moving ipykernel (and potentially other example-only libs) to an extras group (e.g., [project.optional-dependencies].notebooks) to keep the core footprint minimal.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Fix and resolve conversation

"rich>=13.7.0",
"prompt-toolkit>=3.0.47",
"ipykernel>=7.0.1",
"openai==2.5.0",
Copy link

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Exact pinning of openai while other dependencies use ranges can cause avoidable resolution conflicts and delay security/bugfix updates; prefer a compatible range like openai>=2.5.0,<3.0 unless a strict freeze is required.

Suggested change
"openai==2.5.0",
"openai>=2.5.0,<3.0",

Copilot uses AI. Check for mistakes.
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 37 to +43
"mem0ai==1.0.0",
"rich>=13.7.0",
"prompt-toolkit>=3.0.47",
"ipykernel>=7.0.1",
"openai==2.5.0",
"azure-ai-evaluation>=1.12.0",
"tiktoken>=0.12.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Resolve conflicting tiktoken dependency constraints

The dependency list now contains both "tiktoken>=0.7.0,<0.8" and "tiktoken>=0.12.0". Package installers treat duplicate requirements as an intersection, so there is no version that satisfies both ranges and uv sync/pip install . will fail with an unsatisfiable requirement before the project can even be set up. Drop the old constraint or move the upgraded version to an optional extra to keep installs workable.

Useful? React with 👍 / 👎.

Comment on lines +44 to +78
frontend-install:
@echo "Installing frontend dependencies..."
cd src/frontend && npm install
@echo "✓ Frontend dependencies installed"

# Run application
run:
uv run python -m agenticfleet

# Full stack development (backend + frontend)
dev:
@echo "Starting AgenticFleet Full Stack Development..."
@echo ""
@echo "Backend: http://localhost:8000"
@echo "Frontend: http://localhost:5173"
@echo ""
@echo "Press Ctrl+C to stop both services"
@echo ""
@trap 'kill 0' INT; \
uv run uvicorn agenticfleet.haxui.api:app --reload --port 8000 & \
cd src/frontend && npm run dev

# Examples
demo-hitl:
uv run python examples/demo_hitl.py

# DevUI backend server only
haxui-server:
@echo "Starting HaxUI backend on http://localhost:8000"
uv run uvicorn agenticfleet.haxui.api:app --reload --port 8000

# Frontend dev server only
frontend-dev:
@echo "Starting frontend on http://localhost:5173"
cd src/frontend && npm run dev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid Make targets referencing missing frontend directory

frontend-install, dev, and frontend-dev all cd src/frontend, but no such directory exists in the repository (find . -name frontend returns nothing). Each advertised command will fail immediately with cd: src/frontend: No such file or directory, so developers cannot run the new full‑stack targets at all. Either add the frontend sources or guard these targets so they only run when the directory is present.

Useful? React with 👍 / 👎.

@Zochory Zochory merged commit 4cf3da8 into main Oct 19, 2025
59 of 66 checks passed
@Zochory Zochory deleted the feature/notebooks-examples branch October 19, 2025 19:29
@github-project-automation github-project-automation bot moved this from Backlog to Done in AgenticFleet Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency updates

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants