Skip to content

Fix RollingWindow element order corruption on resize#9449

Merged
Martin-Molinero merged 3 commits intoQuantConnect:masterfrom
JosueNina:bug-9355-indicator-window-inconsistencies
May 7, 2026
Merged

Fix RollingWindow element order corruption on resize#9449
Martin-Molinero merged 3 commits intoQuantConnect:masterfrom
JosueNina:bug-9355-indicator-window-inconsistencies

Conversation

@JosueNina
Copy link
Copy Markdown
Collaborator

Description

When resizing a full RollingWindow, the internal write position was not accounted for, causing index calculations to return elements in the wrong order. Fix reorders the internal list to match the new layout before resizing.

Related Issue

Closes #9355

Motivation and Context

N/A

Requires Documentation Change

N/A

How Has This Been Tested?

It was tested using unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Copy Markdown
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Martin-Molinero Martin-Molinero merged commit 421d3c3 into QuantConnect:master May 7, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indicator Window Inconsistencies

2 participants