Merged
Conversation
mmcky
approved these changes
Feb 22, 2023
Contributor
|
thanks @oyamad |
oyamad
added a commit
that referenced
this pull request
Feb 22, 2023
mmcky
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Add discrete_var Co-Authored-By: John Stachurski <john.stachurski@gmail.com> Co-Authored-By: Carlos Rondón-Moreno <31420139+crondonm@users.noreply.github.com> * Add suggestions by @crondonm Co-Authored-By: Carlos Rondón-Moreno <31420139+crondonm@users.noreply.github.com> * Add discrete_var in approximation * Add tests Co-Authored-By: John Stachurski <john.stachurski@gmail.com> Co-Authored-By: Carlos Rondón-Moreno <31420139+crondonm@users.noreply.github.com> * add suggestions 1, 2, 5 by @jstac * Add docs of Pi and S in output. * Remove row_major argument and use cartesian from gridtools * Modify tests to drop row_major * Rename Pi to P * use mlinspace * Implement discrete_var using quantecon functions * Use `fit_discrete_mc` * Remove unused import * Remove unused import * adjust test and docstring * Edit docstring * Import _lss and _matrix_eqn * add new tests and bug fixing * add tests for non-square C * adjust docstring * Minor edits in docstring * adjust based on review * update docstring * set unit Cov for t-distribution * CI: Workaround for windows (#694) --------- Co-authored-by: Smit-create <smitlunagariya.mat18@itbhu.ac.in> Co-authored-by: John Stachurski <john.stachurski@gmail.com> Co-authored-by: Shu <shu.hu@anu.edu.au> Co-authored-by: Daisuke Oyama <oyama@e.u-tokyo.ac.jp> Co-authored-by: Humphrey Yang <humphrey.yang@anu.edu.au> Co-authored-by: Humphrey Yang <u6474961@anu.edu.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix the error reported in #640 (comment).