french_rev set: record the repoint of the five Sargent-Velde datasets - #49
Merged
Conversation
Flips assignat.xlsx, dette.xlsx, fig_3.xlsx, caron.npy and nom_balances.npy from landed to repointed, and fills in their consumers now that both lectures read them from here. migration.yml is 18 repointed, 0 landed. Hold this as a draft until QuantEcon/lecture-python-intro#826 and QuantEcon/lecture-wasm#55 have both merged. `build_audit.py` scans each consuming repo's origin/main, so while those PRs are open a strict run reports five migration_inconsistencies and exits 1 — the deliberate no-green-state window for a partially-repointed dataset (repoint rule 2). It goes green once both land; nothing else is required here. Also drops nine stale mirror-orphan annotations for lecture-wasm files that no longer exist. Six are deleted by lecture-wasm#55 in this same set; the other three (chapter_3.xlsx, longprices.xls, mpd2020.xlsx) were deleted during sets 1 and 2 and their annotations were left behind. All nine confirmed absent from that repo's working tree. check_consumed_files.py now covers 18 of 18 files, 0 errors — the five new consumer entries put these datasets under the required byte check for the first time. Part of QuantEcon/workspace-lectures#23.
This was referenced Aug 6, 2026
mmcky
added a commit
to QuantEcon/lecture-python-intro
that referenced
this pull request
Aug 6, 2026
Repoints all five french_rev datasets onto QuantEcon/data-lectures:
assignat.xlsx, dette.xlsx and fig_3.xlsx via the base_url f-string, and
caron.npy and nom_balances.npy, which were local-path reads.
The two .npy reads are the substantive fix. `np.load('datasets/caron.npy')`
resolves only when the working directory happens to be `lectures/`, so the
downloaded notebook raised FileNotFoundError in Colab and anywhere else a
reader ran it. They now fetch over HTTP and load through BytesIO, matching
the idiom lecture-wasm already uses. These were the last local-path data
reads in this repo.
The three markdown links under "Data Sources" are repointed too. They are
prose, so no build checks them, and they would have 404'd once this repo's
copies are deleted.
Verified: all five served from data-lectures are byte-identical (sha256) to
the copies this lecture read before, and to each dataset's manifest; both
.npy files load to identical arrays, shape and dtype.
This repo's copies under lectures/datasets/ are deliberately kept in this PR
and deleted in a follow-up once the site is published, per repoint rule 3 —
the published notebook lags main and would 404 in the gap.
Part of QuantEcon/workspace-lectures#23. Data: QuantEcon/data-lectures#49.
mmcky
added a commit
to QuantEcon/lecture-wasm
that referenced
this pull request
Aug 6, 2026
Repoints french_rev off lecture-python-intro's committed copies and onto QuantEcon/data-lectures, and deletes this repo's unused mirror copies. The URL form stays raw.githubusercontent.com, per repoint rule 5 — this site executes its code cells in the reader's browser, and the github.com/*/raw/ form is a 302 whose response carries an empty access-control-allow-origin. Only base_url's org, repo and path change. Verified: all five files return 200 with access-control-allow-origin: * on this host, serving bytes identical to the copies the lecture read before. The six deleted files under lectures/datasets/ were mirror-orphans — nothing in this repo read them, since french_rev has always fetched intro's copies by URL. fig_3.ods is included: it is a format twin of fig_3.xlsx that nothing anywhere references, and data-lectures dropped it for that reason. The two remaining files in that directory belong to another lecture. The three markdown links under "Data Sources" are repointed as well. They pointed into lecture-python-intro and no build checks them, so they would have 404'd silently once intro deletes its copies. Pairs with QuantEcon/lecture-python-intro#826 — both must land together, per repoint rule 2. Part of QuantEcon/workspace-lectures#23. Data: QuantEcon/data-lectures#49.
mmcky
marked this pull request as ready for review
August 6, 2026 23:52
There was a problem hiding this comment.
Pull request overview
Records the french_rev repoint by updating the migration tracker and manifest consumer lists for five Sargent–Velde datasets, regenerating the dataset catalog accordingly, and cleaning up stale audit annotations tied to now-absent lecture-wasm files.
Changes:
- Move five datasets (
assignat.xlsx,dette.xlsx,fig_3.xlsx,caron.npy,nom_balances.npy) fromlanded→repointedinmigration.yml, adding repoint PR references. - Populate
consumersfor the same five datasets’ sidecar manifests so they are tracked by consumed-files checks and appear as “Used by” in the catalog. - Remove nine stale
mirror-orphanentries fromscripts/audit_annotations.ymland regenerateCATALOG.md.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/audit_annotations.yml | Removes stale lecture-wasm mirror-orphan annotations for datasets no longer present there. |
| migration.yml | Marks the five french_rev datasets as repointed and records repoint PR references/dates. |
| lectures/assignat.xlsx.yml | Adds consumers entries for lecture repos consuming this dataset. |
| lectures/dette.xlsx.yml | Adds consumers entries for lecture repos consuming this dataset. |
| lectures/fig_3.xlsx.yml | Adds consumers entries for lecture repos consuming this dataset. |
| lectures/caron.npy.yml | Adds consumers entries for lecture repos consuming this dataset. |
| lectures/nom_balances.npy.yml | Adds consumers entries for lecture repos consuming this dataset. |
| CATALOG.md | Regenerated registry reflecting 18/18 datasets read by lectures and updated “Used by” rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mmcky
added a commit
to QuantEcon/lecture-python-intro
that referenced
this pull request
Aug 7, 2026
…hed (#827) Phase 2 of the french_rev repoint. #826 moved the reads to data-lectures but deliberately kept these files; publish-2026aug07 has now refreshed the site, so nothing reads them any more. Verified before deleting, against the deployed artifact rather than main: the notebook served at intro.quantecon.org/_notebooks/french_rev.ipynb carries four data-lectures references, zero references to lectures/datasets/, and no local-path np.load. The wasm site's french-rev page likewise carries zero references to this repo and five raw.githubusercontent.com reads of data-lectures. An org-wide sweep over every repo's origin/main finds no remaining reader of these five paths; the only matches are data-lectures' own manifests and audit annotations. fig_3.ods stays. It is an orphan rather than part of this set, and unlike wasm's copy it is the last one in the org — data-lectures dropped it as a verified format twin of fig_3.xlsx. Retiring it is Track X's call, with the sweep that covers the other two files left in this directory. Part of QuantEcon/workspace-lectures#23. Completes the set recorded in QuantEcon/data-lectures#49.
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the
french_revrepoint:assignat.xlsx,dette.xlsx,fig_3.xlsx,caron.npyandnom_balances.npymove fromlandedtorepointed, with theirconsumersfilled in.migration.ymlis now 18 repointed, 0 landed. Part of QuantEcon/workspace-lectures#23 (step 2).Draft on purpose — merge last
Hold until QuantEcon/lecture-python-intro#826 and QuantEcon/lecture-wasm#55 have both merged.
build_audit.pyscans each consuming repo'sorigin/main, not its branches. While those two PRs are open, a strict run reports fivemigration_inconsistenciesand exits 1:That is the intended no-green-state window for a partially-repointed dataset (repoint rule 2), not a defect in this PR. It clears the moment both lecture PRs land, and nothing further is needed here.
What is in the diff
Five manifests gain their
consumersentries. This puts these datasets undercheck_consumed_files.py— the requiredconsumed-filescheck — for the first time: it now covers 18 of 18 files, 0 errors, up from 13.CATALOG.mdregenerates to 18 datasets · 18 read by lectures today, replacing 13 read by lectures today, 5 awaiting repoint.Nine stale mirror-orphan annotations are dropped from
scripts/audit_annotations.yml, forlecture-wasmfiles that no longer exist. Six are deleted by lecture-wasm#55 in this same set. The other three —chapter_3.xlsx,longprices.xls,mpd2020.xlsx— were deleted during sets 1 and 2 and their annotations were simply left behind; all nine confirmed absent from that repo.Integrity
Each file was fetched from this repo over both consumer URL forms and compared against the copy the lectures read before the repoint. All five are byte-identical to the old copies and to their manifest
integrity.sha256; both.npyfiles load to identical arrays, shape and dtype. Evidence is in QuantEcon/lecture-python-intro#826 and QuantEcon/lecture-wasm#55.Still outstanding for this set after these three merge
Phase 2 — publish
lecture-python-intro, then delete its five copies underlectures/datasets/in a follow-up PR, per repoint rule 3.🤖 Generated with Claude Code