Skip to content

BUG: Remove x_validate and y_validate as they're unnecessary #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmcky merged 1 commit into from
Dec 8, 2025
Merged

BUG: Remove x_validate and y_validate as they're unnecessary #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lectures/jax_nn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,6 @@ def train_jax_model(
θ: list, # Initial parameters (pytree)
x: jnp.ndarray, # Training input data
y: jnp.ndarray, # Training target data
x_validate: jnp.ndarray, # Validation input data
y_validate: jnp.ndarray, # Validation target data
config: Config # contains configuration data
):
"""
Expand Down Expand Up @@ -473,12 +471,12 @@ param_key = jax.random.PRNGKey(1234)
θ = initialize_network(param_key, config)

# Warmup run to trigger JIT compilation
train_jax_model(θ, x_train, y_train, x_validate, y_validate, config)
train_jax_model(θ, x_train, y_train, config)

# Reset and time the actual run
θ = initialize_network(param_key, config)
start_time = time()
θ = train_jax_model(θ, x_train, y_train, x_validate, y_validate, config)
θ = train_jax_model(θ, x_train, y_train, config)
θ[0].W.block_until_ready() # Ensure computation completes
jax_runtime = time() - start_time

Expand Down
Loading