np.ones * alpha -->> np.full #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstac
reviewed
Jul 18, 2021
lectures/markov_asset.md
Outdated
| I = np.identity(n) | ||
| v = solve(I - β * K, β * K @ np.ones(n)) | ||
| v = solve(I - β * K, K @ np.full(n, β)) |
Contributor
There was a problem hiding this comment.
@shlff , please revert this back to the original, since the original is a bit closer to the maths. Thanks.
jstac
reviewed
Jul 18, 2021
lectures/markov_asset.md
Outdated
| I = np.identity(ap.n) | ||
| Ones = np.ones(ap.n) | ||
| v = solve(I - β * J, β * J @ Ones) | ||
| Full = np.full(ap.n, β) |
Contributor
There was a problem hiding this comment.
@shlff , please revert this back to the original. Ones is a natural matrix and the code is easier to read in the original.
jstac
reviewed
Jul 18, 2021
lectures/markov_asset.md
Outdated
| I = np.identity(ap.n) | ||
| Ones = np.ones(ap.n) | ||
| p = solve(I - β * M, β * ζ * M @ Ones) | ||
| Full = np.full(ap.n, β * ζ) |
oyamad
reviewed
Jul 18, 2021
lectures/complex_and_trig.md
Outdated
| π = np.pi | ||
| zeros = np.zeros | ||
| ones = np.ones | ||
| full = np.full |
Member
There was a problem hiding this comment.
I don't think this is a good strategy. One can use just np.full in line 140 (only one place).
Same for zeros.
Member
Author
oyamad
approved these changes
Jul 18, 2021
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jstac and @oyamad , thanks for your nice comments. This PR fix #165 's remaining patterns, mentioned by @oyamad , except for the following:
V = np.ones(len(mcm.w_vec))Do you think we should also change the
np.onespattern tonp.fullin the above lecture?