Conversation
✅ Deploy Preview for timely-seahorse-68815c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
…#54) Lands #51, #52, #53 and #50 as one change, and salvages the -n flag from #25. - runs-on: disk=large -> volume=80gb, plus spot=false, on all four GPU workflows. Now matches lecture-jax and lecture-python.myst byte for byte, allowing for collab.yml's different image. - Explicit permissions blocks on ci.yml, collab.yml and publish.yml so the default workflow token can drop to read. ci.yml and collab.yml also gain actions: read, which #53 declared only on publish.yml. - dawidd6/action-download-artifact -> @v21 at all four call sites; collab.yml was still on v3 while the rest were on v9. - -n added to the ci.yml PDF build so it matches publish.yml, closing a gap where a nitpick-class error passed the PR check and failed at publish time. #51, #52 and #53 conflicted pairwise over the same region of ci.yml and collab.yml, so they are resolved once here rather than through two sequential rebases. Part of the rollout tracked in QuantEcon/meta#330, with the permissions work from QuantEcon/meta#347. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Closing as superseded, with one line carried forward. The markdown half is already on main. 230e90c refreshed The Not carried forward: the One thing this closure does not resolve. I could not confirm whether the original unicode-in-PDF failure still reproduces, because |
This PR is trying to fix the broken
pdfbuilds on publish