Skip to content

FIX: fixes for PDF builder - #25

Closed
mmcky wants to merge 4 commits into
mainfrom
fix-pdf
Closed

FIX: fixes for PDF builder#25
mmcky wants to merge 4 commits into
mainfrom
fix-pdf

Conversation

@mmcky

@mmcky mmcky commented May 3, 2024

Copy link
Copy Markdown
Contributor

This PR is trying to fix the broken pdf builds on publish

@netlify

netlify Bot commented May 3, 2024

Copy link
Copy Markdown

Deploy Preview for timely-seahorse-68815c ready!

Name Link
🔨 Latest commit 29226af
🔍 Latest deploy log https://app.netlify.com/sites/timely-seahorse-68815c/deploys/67ab1e3acd5a850008e35322
😎 Deploy Preview https://deploy-preview-25--timely-seahorse-68815c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions

github-actions Bot commented May 3, 2024

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request May 3, 2024 01:46 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request May 3, 2024 01:59 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request May 3, 2024 02:22 Inactive
@mmcky

mmcky commented May 3, 2024

Copy link
Copy Markdown
Contributor Author
  • for some reason the PDF builder is not triggering a failure condition -- but it is failing on the pdf build due to unsupported unicode characters in code generated outputs.

@mmcky

mmcky commented Jun 13, 2024

Copy link
Copy Markdown
Contributor Author
  • migrate to use local github actions instance and then diagnose issue to see if latex issue is due to EC2 environment
  • fixes or add support for new unicode characters in pdf

mmcky added a commit that referenced this pull request Aug 5, 2026
…#54)

Lands #51, #52, #53 and #50 as one change, and salvages the -n flag from #25.

- runs-on: disk=large -> volume=80gb, plus spot=false, on all four GPU
  workflows. Now matches lecture-jax and lecture-python.myst byte for byte,
  allowing for collab.yml's different image.
- Explicit permissions blocks on ci.yml, collab.yml and publish.yml so the
  default workflow token can drop to read. ci.yml and collab.yml also gain
  actions: read, which #53 declared only on publish.yml.
- dawidd6/action-download-artifact -> @v21 at all four call sites; collab.yml
  was still on v3 while the rest were on v9.
- -n added to the ci.yml PDF build so it matches publish.yml, closing a gap
  where a nitpick-class error passed the PR check and failed at publish time.

#51, #52 and #53 conflicted pairwise over the same region of ci.yml and
collab.yml, so they are resolved once here rather than through two sequential
rebases. Part of the rollout tracked in QuantEcon/meta#330, with the
permissions work from QuantEcon/meta#347.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@mmcky

mmcky commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded, with one line carried forward.

The markdown half is already on main. 230e90c refreshed bayes_nonconj.md from lecture-python.myst, dropping the raw <u> HTML and the paramter typo this PR fixed, and going further by wrapping the sentence in a {note} admonition. That is also the sole merge conflict here — the branch conflicts on the exact line it was opened to fix, and main's resolution is the better one.

The -n addition was a genuine fix and has been carried into #54. ci.yml's PDF build was the only jb build in that file without -n, while publish.yml runs the same pdflatex build with -n -W. That gap let a bad cross-reference or missing citation pass the PR check and then fail the tag-only publish build.

Not carried forward: the build-folder upload step, which lacks the if: failure() guard its three siblings have and so would upload the whole _build tree on every run.

One thing this closure does not resolve. I could not confirm whether the original unicode-in-PDF failure still reproduces, because ci.yml currently dies at the pip install step and never reaches the PDF build. There is no latex preamble in lectures/_config.yml, which suggests the root cause was never addressed. If it is still live it deserves a fresh issue against the current RunsOn environment rather than reviving this branch, whose assumptions (EC2, pre-refresh bayes_nonconj.md) no longer hold.

@mmcky mmcky closed this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant