test: re-baseline visual harness to v2.0.0#65
Merged
Conversation
Regenerate the Playwright snapshot baselines against a local v2.0.0 build (@myst-theme 1.3.0, Remix ~1.17.0), replacing the v1.1.1 baselines that were captured to validate the upgrade. The harness now guards the shipped 2.0.0 rendering: centered content column, restored "On this page" outline, and the new @myst-theme 1.x notebook output-node AST (stream / execute_result / error). 6/6 snapshots stable on a verification run. Also refresh tests/visual/README.md to describe the ongoing "validate a change" workflow now that 2.0.0 is the baseline. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Re-baselines the Playwright visual-regression harness so that committed snapshots reflect the shipped v2.0.0 rendering (post @myst-theme 1.x upgrade), and updates the visual-test documentation to describe the ongoing “validate a change” workflow against those baselines.
Changes:
- Regenerates the 6 Playwright snapshot baselines (intro/features/notebook × desktop/mobile) for the v2.0.0 look.
- Updates
tests/visual/README.mdto reflect the new baseline and the standard diff/update workflow usingtest:visual/test:visual:update.
Reviewed changes
Copilot reviewed 1 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/visual/README.md | Updates the visual-harness documentation to reflect v2.0.0 baselines and the current validation workflow. |
| tests/visual/snapshots/desktop-chrome/intro.png | Updated desktop baseline snapshot for the intro surface. |
| tests/visual/snapshots/desktop-chrome/features.png | Updated desktop baseline snapshot for the features surface. |
| tests/visual/snapshots/desktop-chrome/notebook.png | Updated desktop baseline snapshot for the notebook surface. |
| tests/visual/snapshots/mobile-chrome/intro.png | Updated mobile baseline snapshot for the intro surface. |
| tests/visual/snapshots/mobile-chrome/features.png | Updated mobile baseline snapshot for the features surface. |
| tests/visual/snapshots/mobile-chrome/notebook.png | Updated mobile baseline snapshot for the notebook surface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nned release Addresses Copilot review on #65 — 'A deployed release' implied a versioned artifact, but the example points at the build repo's unpinned main.zip. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-baseline the visual harness to v2.0.0
Follow-up to the 2.0.0 release prep (#64). Now that 2.0.0 is on
mainand its rendering is verified, regenerate the Playwright baselines so the harness guards the shipped look instead of v1.1.1.What changed
intro/features/notebook× desktop + mobile) against a local v2.0.0 build (@myst-theme1.3.0, Remix~1.17.0).tests/visual/README.mdto describe the ongoing "validate a change" workflow (build candidate →test:visual→ diff →test:visual:updatewhen intentional), now that 2.0.0 is the baseline rather than the one-time "validate the 0.14 → 1.x move" framing.What the new baselines capture
The correct 2.0.0 rendering — centered content column, restored "On this page" outline, and the new
@myst-theme1.x notebook output-node AST (stream /execute_result/ error traceback).Verification
test:visual:update, then confirmed stable with a plaintest:visualrun: 6/6 pass.🤖 Generated with Claude Code