chore(deps): resolve safe Dependabot advisories via overrides + triage doc#68
Open
mmcky wants to merge 1 commit into
Open
chore(deps): resolve safe Dependabot advisories via overrides + triage doc#68mmcky wants to merge 1 commit into
mmcky wants to merge 1 commit into
Conversation
`npm audit fix` is a no-op for this tree — every advisory needs either a major bump or a manual override. Pull forward the three transitive deps that have backward-compatible patched releases: - uuid -> ^11.1.1 (GHSA-w5hq-g745-h8pq) - ajv -> ^8.18.0 (GHSA-2g4f-4pwh-qvx6) - cookie -> ^0.7.0 (GHSA-pxg6-pf52-xh8x; used by Remix cookie sessions) This drops the audit count 48 -> 39 with no toolchain major bumps. The lockfile change is almost entirely deduplication onto the overridden versions. compile + prod:build verified. Add SECURITY.md documenting the dependency posture and triaging the remaining alerts: the deliberate Remix-v1 pin (advisories patched only in v2; the critical @remix-run/node file-session-storage CVE is N/A since the theme uses cookie sessions), the unmaintained `ip` package (no fix), and the major-bump MyST/Thebe build-chain deps (deferred to upstream). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces actionable Dependabot/npm-audit security alerts without migrating off the intentionally pinned Remix v1.17 line by adding npm overrides for selected transitive dependencies, and documents the remaining deferred alerts/decisions in a new SECURITY.md.
Changes:
- Add npm
overridesforuuid,ajv, andcookieto pull in patched transitive versions without major bumps. - Update
package-lock.jsonto reflect deduplication/resolution onto the overridden versions. - Add
SECURITY.mdcapturing the dependency security posture and triage of remaining alerts, plus a changeset entry.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SECURITY.md | New security policy/posture & alert triage documentation (including rationale for deferred advisories). |
| package.json | Adds overrides entries for uuid, ajv, and cookie. |
| package-lock.json | Lockfile update reflecting dependency resolution/deduplication under the new overrides. |
| .changeset/security-deps-overrides.md | Release note describing the security override changes and new documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| | Package(s) | Severity | Status | | ||
| | ---------------------------------------------------------------------- | -------- | ------------------------------------------------------------------------------------------------------- | | ||
| | `@remix-run/node` (GHSA-9583-h5hc-x8cw) | critical | **Not applicable** — path traversal in *file* session storage; this theme uses `createCookieSessionStorage`. | |
| "@curvenote/quantecon-book": patch | ||
| --- | ||
|
|
||
| Resolve backward-compatible Dependabot security advisories via `overrides`: `uuid` (→11.1.1), `ajv` (→8.18.0), and `cookie` (→0.7.0, used by Remix's cookie session). Add `SECURITY.md` documenting the dependency posture and triage for the remaining alerts (deferred Remix-v1, the unmaintained `ip` package, and major-bump MyST/Thebe build-chain deps). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviews the open Dependabot security alerts and resolves the ones that can be fixed without a breaking/major bump, then documents the rest. Scope was deliberately kept conservative to preserve the hard-won Remix v1.17 stability (#61–#65).
Key context
npm audit fixis a no-op on this tree — every remaining advisory needs either a--forcemajor bump or a manualoverridesentry..npmrc+ fix: pin @remix-run/* to ~1.17.0 to stop the hydration reload loop #63). Most Remix advisories are patched only in v2, which re-introduces the hydration reload loop. Those are deferred, not fixed.What this PR changes
Three backward-compatible transitive deps pulled forward via
overridesin package.json:uuid^11.1.1ajv^8.18.0cookie^0.7.0Net effect:
npm audit48 → 39. Thepackage-lock.jsonchange is +12/−88 — almost entirely deduplication onto the overridden versions.Plus a new SECURITY.md documenting the dependency posture and triaging every remaining alert.
Triage of the deferred alerts (in SECURITY.md)
@remix-run/nodealert (GHSA-9583, path traversal in file session storage) is not applicable — the theme usescreateCookieSessionStorage, not file sessions.ip(high) — unmaintained, no patched release exists; dev/transitive only.markdown-it13→14,nanoid4→5,ws7→8,tar6→7,vite5→6,esbuild,estree-util-value-to-estree,yaml) — high regression risk for low real exposure (dev/build-time or bundled static assets); deferred to upstream.Testing
npm install— clean (with the repo'slegacy-peer-deps)npm run compile(tsc) — passesnpm run prod:build— builds cleanuuid/ajv/cookieconfirmed deduped to the patched versions across the tree and no longer flagged bynpm auditcookie0.4→0.7 sits under Remix v1's cookie session signing. The build passes and usage is a simple theme-preference cookie, but a quick check that light/dark theme persistence still round-trips on the deployed app is worth doing before merge.A changeset (
patch) is included.🤖 Generated with Claude Code