Skip to content

feat(dual-review): wire promotion and drift gates to pipeline#35

Merged
Pigbibi merged 5 commits into
mainfrom
feat/dual-review-gate-wiring
Jul 8, 2026
Merged

feat(dual-review): wire promotion and drift gates to pipeline#35
Pigbibi merged 5 commits into
mainfrom
feat/dual-review-gate-wiring

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • 新增 Codex 主审 (dual_review_primary) 与 Gateway 次审 (dual_review_gateway),CI 并行 GPT+Claude
  • run_dual_review_pipeline.py:证据包 → 主审 → 次审 → compare → 可选 --dispatch
  • run_drift_dual_review.py:对 drift detection 中 critical 策略批量跑 pipeline
  • resolve_secondary_reviewer():gateway URL 优先,stub 模式用于测试

Test plan

  • ruff check .
  • python -m unittest discover -s tests (516 tests OK)
  • 合并后四策略仓 evidence-gate / drift-check workflow 接线 PR 依赖本 PR

Made with Cursor

Add Codex primary + gateway secondary reviewers, end-to-end pipeline
scripts, and drift critical-strategy batch runner for evidence-gate CI.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 8, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

🤖 Codex PR Review

⚠️ Human review required: The Codex review could not be completed.

Codex service job failed: codex exec failed (rc=1):
ne_disagreement_exit_shape(self, mock_orchestrate) -> None:
+        from service.dual_review import DualReviewTrigger
+        from service.dual_review_orchestrator import DualReviewResult
+
+        mock_orchestrate.return_value = DualReviewResult(
+            trigger=DualReviewTrigger.DRIFT,
+            strategy_profile="demo",
+            primary_review={"verdict": "approve", "confidence": 0.4},
+            outcome="disagreement",
+        )
+        result = run_pipeline(
+            trigger="drift",
+            strategy_profile="demo",
+            context

Please ensure a human reviewer checks this PR before merging.

Resolve drift pipeline path, make --from-evidence CLI usable, inject
evidence_summary into promotion context, and harden primary review errors.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 8, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Fail closed when Codex primary is missing, validate --from-evidence
packages, stop using CODEX_AUDIT_SERVICE_URL as gateway URL, and isolate
per-provider gateway analyze failures.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 8, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented Jul 8, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@cursor

cursor Bot commented Jul 8, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Pigbibi Pigbibi merged commit d483ea1 into main Jul 8, 2026
3 of 5 checks passed
@Pigbibi Pigbibi deleted the feat/dual-review-gate-wiring branch July 8, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant