Skip to content

fix: reject non-boolean Binance buyer flags - #206

Merged
Pigbibi merged 1 commit into
mainfrom
codex/binance-strict-bool-20260904
Sep 4, 2026
Merged

fix: reject non-boolean Binance buyer flags#206
Pigbibi merged 1 commit into
mainfrom
codex/binance-strict-bool-20260904

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • reject non-boolean isBuyer values during read-only reconciliation
  • add regression coverage for string, missing, and numeric values

Scope

  • no workflow, dependency, persistence, order, provider, or credential changes
  • reconciliation remains fail-closed

Validation

  • uv run --no-sync python -m pytest -q tests/test_broker_reconciliation.py
  • uv run --no-sync ruff check application/broker_reconciliation.py tests/test_broker_reconciliation.py
  • git diff --check

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 3a273c9 into main Sep 4, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/binance-strict-bool-20260904 branch September 4, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant